# [PATCH] t4205: fix typo in 'NUL termination with --stat'

2 messages from 2024-10-20 to 2024-10-21. Participants: Kousik Sanagavarapu, Taylor Blau.
Thread: https://gitlist.dev/t/62378

## Kousik Sanagavarapu, 2024-10-20 19:18

Subject: [PATCH] t4205: fix typo in 'NUL termination with --stat'
Message-ID: <20241020191910.31096-1-five231003@gmail.com>
URL: https://gitlist.dev/e/20241020191910.31096-1-five231003%40gmail.com

```
Correct "expected" to rightly terminate with NUL ie '\0' instead of '0'
which may have been typoed.

We didn't notice this before because the test is run with
"test_expect_failure", meaning the test would have been marked broken
anyways.

Signed-off-by: Kousik Sanagavarapu <five231003@gmail.com>
---
 t/t4205-log-pretty-formats.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/t/t4205-log-pretty-formats.sh b/t/t4205-log-pretty-formats.sh
index eb63ce011f..57b8b79738 100755
--- a/t/t4205-log-pretty-formats.sh
+++ b/t/t4205-log-pretty-formats.sh
@@ -137,7 +137,7 @@ test_expect_success 'NUL separation with --stat' '
 test_expect_failure 'NUL termination with --stat' '
 	stat0_part=$(git diff --stat HEAD^ HEAD) &&
 	stat1_part=$(git diff-tree --no-commit-id --stat --root HEAD^) &&
-	printf "add bar\n$stat0_part\n\0$(commit_msg)\n$stat1_part\n0" >expected &&
+	printf "add bar\n$stat0_part\n\0$(commit_msg)\n$stat1_part\n\0" >expected &&
 	git log -z --stat --pretty="tformat:%s" >actual &&
 	test_cmp expected actual
 '
-- 
2.47.0.107.g34b6ce9b30


```

## Taylor Blau, 2024-10-21 21:36

Subject: Re: [PATCH] t4205: fix typo in 'NUL termination with --stat'
Message-ID: <ZxbJeSozYRPattwq@nand.local>
URL: https://gitlist.dev/e/ZxbJeSozYRPattwq%40nand.local
In-Reply-To: <20241020191910.31096-1-five231003@gmail.com>

```
On Mon, Oct 21, 2024 at 12:48:47AM +0530, Kousik Sanagavarapu wrote:
>  t/t4205-log-pretty-formats.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks for finding and fixing. Let's merge this one down.

Thanks,
Taylor

```