git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] t4205: fix typo in 'NUL termination with --stat'

From
Kousik Sanagavarapu <five231003@gmail.com>
Date
Oct 20, 2024, 19:18 UTC
Message-ID
<20241020191910.31096-1-five231003@gmail.com>

Correct "expected" to rightly terminate with NUL ie '\0' instead of '0' which may have been typoed.

We didn't notice this before because the test is run with "test_expect_failure", meaning the test would have been marked broken anyways.

Signed-off-by: Kousik Sanagavarapu <five231003@gmail.com>
---
 t/t4205-log-pretty-formats.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t4205-log-pretty-formats.sh b/t/t4205-log-pretty-formats.sh
index eb63ce011f..57b8b79738 100755
--- a/t/t4205-log-pretty-formats.sh
+++ b/t/t4205-log-pretty-formats.sh
@@ -137,7 +137,7 @@ test_expect_success 'NUL separation with --stat' '
 test_expect_failure 'NUL termination with --stat' '
 	stat0_part=$(git diff --stat HEAD^ HEAD) &&
 	stat1_part=$(git diff-tree --no-commit-id --stat --root HEAD^) &&
-	printf "add bar\n$stat0_part\n\0$(commit_msg)\n$stat1_part\n0" >expected &&
+	printf "add bar\n$stat0_part\n\0$(commit_msg)\n$stat1_part\n\0" >expected &&
 	git log -z --stat --pretty="tformat:%s" >actual &&
 	test_cmp expected actual
 '
-- 
2.47.0.107.g34b6ce9b30
Next: Taylor Blau
Message 1 of 2 in “t4205: fix typo in 'NUL termination with --stat'”
  1. t4205: fix typo in 'NUL termination with --stat'Kousik Sanagavarapu, Oct 20, 2024
  2. Taylor BlauOct 21, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.