{"thread":{"id":"62378","subject":"[PATCH] t4205: fix typo in 'NUL termination with --stat'","startedAt":"2024-10-20T19:19:18Z","lastAt":"2024-10-21T21:36:59Z","messageCount":2,"participants":["Kousik Sanagavarapu","Taylor Blau"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"505575","messageId":"20241020191910.31096-1-five231003@gmail.com","threadId":"62378","inReplyTo":null,"subject":"[PATCH] t4205: fix typo in 'NUL termination with --stat'","fromName":"Kousik Sanagavarapu","fromEmail":"five231003@gmail.com","sentAt":"2024-10-20T19:18:47Z","receivedAt":"2024-10-20T19:19:18Z","isPatch":true,"sender":{"key":"five231003@gmail.com","avatar":"https://avatars.githubusercontent.com/u/75560439?v=4"},"body":"Correct \"expected\" to rightly terminate with NUL ie '\\0' instead of '0'\nwhich may have been typoed.\n\nWe didn't notice this before because the test is run with\n\"test_expect_failure\", meaning the test would have been marked broken\nanyways.\n\nSigned-off-by: Kousik Sanagavarapu <five231003@gmail.com>\n---\n t/t4205-log-pretty-formats.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t4205-log-pretty-formats.sh b/t/t4205-log-pretty-formats.sh\nindex eb63ce011f..57b8b79738 100755\n--- a/t/t4205-log-pretty-formats.sh\n+++ b/t/t4205-log-pretty-formats.sh\n@@ -137,7 +137,7 @@ test_expect_success 'NUL separation with --stat' '\n test_expect_failure 'NUL termination with --stat' '\n \tstat0_part=$(git diff --stat HEAD^ HEAD) &&\n \tstat1_part=$(git diff-tree --no-commit-id --stat --root HEAD^) &&\n-\tprintf \"add bar\\n$stat0_part\\n\\0$(commit_msg)\\n$stat1_part\\n0\" >expected &&\n+\tprintf \"add bar\\n$stat0_part\\n\\0$(commit_msg)\\n$stat1_part\\n\\0\" >expected &&\n \tgit log -z --stat --pretty=\"tformat:%s\" >actual &&\n \ttest_cmp expected actual\n '\n-- \n2.47.0.107.g34b6ce9b30\n\n"},{"id":"505779","messageId":"ZxbJeSozYRPattwq@nand.local","threadId":"62378","inReplyTo":"20241020191910.31096-1-five231003@gmail.com","subject":"Re: [PATCH] t4205: fix typo in 'NUL termination with --stat'","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2024-10-21T21:36:57Z","receivedAt":"2024-10-21T21:36:59Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Mon, Oct 21, 2024 at 12:48:47AM +0530, Kousik Sanagavarapu wrote:\n>  t/t4205-log-pretty-formats.sh | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n\nThanks for finding and fixing. Let's merge this one down.\n\nThanks,\nTaylor\n"}]}