threads / patch / 60443

patchchore: fix typo in .clang-format comment

Subject: [PATCH] chore: fix typo in .clang-format comment

## tl;dr

7 messages between Oct 29, 2023 and Oct 31, 2023. Diffs are folded; open one to read it.

replies: 6people: 3as markdown or json

Aditya Neelamraju via GitGitGadget· Oct 29, 2023, 20:23 UTC · lore
From: Aditya Neelamraju <adityanv97@gmail.com>
Signed-off-by: Aditya Neelamraju <adityanv97@gmail.com>
---
    chore: fix typo in .clang-format comment
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1602%2Faneelamr%2Fclang-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1602/aneelamr/clang-v1
Pull-Request: https://github.com/git/git/pull/1602
 .clang-format | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Show changes to .clang-format +3 −3
diff --git a/.clang-format b/.clang-format
index c592dda681f..3ed4fac753a 100644
--- a/.clang-format
+++ b/.clang-format
@@ -83,9 +83,9 @@ BinPackParameters: true
 BreakBeforeBraces: Linux
 
 # Break after operators
-# int valuve = aaaaaaaaaaaaa +
-#              bbbbbb -
-#              ccccccccccc;
+# int value = aaaaaaaaaaaaa +
+#             bbbbbb -
+#             ccccccccccc;
 BreakBeforeBinaryOperators: None
 BreakBeforeTernaryOperators: false
 

base-commit: 2e8e77cbac8ac17f94eee2087187fa1718e38b14
-- 
gitgitgadget
Taylor Blau· Oct 30, 2023, 16:56 UTC · re: Aditya Neelamraju via GitGitGadget · lore

Re: [PATCH] chore: fix typo in .clang-format comment

On Sun, Oct 29, 2023 at 08:23:07PM +0000, Aditya Neelamraju via GitGitGadget wrote:
> From: Aditya Neelamraju <adityanv97@gmail.com>

We typically prefix commit messages with the subject area they're working in, not with "chore", or "feat" like some Git workflows recommend.

That said, the contents of this patch look obviously correct to me. Thanks for noticing and fixing!

Thanks, Taylor

Junio C Hamano· Oct 31, 2023, 03:12 UTC · re: Taylor Blau · lore

Re: [PATCH] chore: fix typo in .clang-format comment

Taylor Blau <me@ttaylorr.com> writes:
Show 9 quoted lines
> On Sun, Oct 29, 2023 at 08:23:07PM +0000, Aditya Neelamraju via GitGitGadget wrote:
>> From: Aditya Neelamraju <adityanv97@gmail.com>
>
> We typically prefix commit messages with the subject area they're
> working in, not with "chore", or "feat" like some Git workflows
> recommend.
> ...
> That said, the contents of this patch look obviously correct to me.
> Thanks for noticing and fixing!

As a comment for a new contributor, it is a bit unhelpful not to suggest what the "subject area" string we would use if we were working on this patch, I think.

I also suspected that valuve may be a valid word in some language, as the indentation in the example looked as if the six-letter word was meant, not typoed. https://www.gasolineravaluve.com/ was one of the first hits I saw in my search ;-)

Taylor Blau· Oct 31, 2023, 19:09 UTC · re: Junio C Hamano · lore

Re: [PATCH] chore: fix typo in .clang-format comment

On Tue, Oct 31, 2023 at 12:12:43PM +0900, Junio C Hamano wrote:
Show 15 quoted lines
> Taylor Blau <me@ttaylorr.com> writes:
>
> > On Sun, Oct 29, 2023 at 08:23:07PM +0000, Aditya Neelamraju via GitGitGadget wrote:
> >> From: Aditya Neelamraju <adityanv97@gmail.com>
> >
> > We typically prefix commit messages with the subject area they're
> > working in, not with "chore", or "feat" like some Git workflows
> > recommend.
> > ...
> > That said, the contents of this patch look obviously correct to me.
> > Thanks for noticing and fixing!
>
> As a comment for a new contributor, it is a bit unhelpful not to
> suggest what the "subject area" string we would use if we were
> working on this patch, I think.

Good suggestion. I would have suggested "clang-format", which is exactly Aditya ended up choosing, anyway. Thanks, Aditya!

> I also suspected that valuve may be a valid word in some language,
> as the indentation in the example looked as if the six-letter word
> was meant, not typoed.  https://www.gasolineravaluve.com/ was one
> of the first hits I saw in my search ;-)
;-)

Thanks, Taylor

Junio C Hamano· Oct 31, 2023, 23:40 UTC · re: Taylor Blau · lore

Re: [PATCH] chore: fix typo in .clang-format comment

Taylor Blau <me@ttaylorr.com> writes:
Show 6 quoted lines
>> As a comment for a new contributor, it is a bit unhelpful not to
>> suggest what the "subject area" string we would use if we were
>> working on this patch, I think.
>
> Good suggestion. I would have suggested "clang-format", which is
> exactly Aditya ended up choosing, anyway. Thanks, Aditya!
Thanks.  I was being lazy when I said the above ;-)

Teaching how to fish instead of giving fish, the way I would have done is

   $ git log --no-merges --stat --full-diff .clang-format

and inspect what they use. The ones that used "clang-format:" are indeed very similar in spirit to what this one does, I would say.

Thanks.
Aditya Neelamraju via GitGitGadget· Oct 31, 2023, 13:40 UTC · re: Aditya Neelamraju via GitGitGadget · lore

[PATCH v2] clang-format: fix typo in comment

From: Aditya Neelamraju <adityanv97@gmail.com>
Signed-off-by: Aditya Neelamraju <adityanv97@gmail.com>
---
    clang-format: fix typo in comment for formatting binary operations.
    
    cc: Taylor Blau me@ttaylorr.com
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1602%2Faneelamr%2Fclang-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1602/aneelamr/clang-v2
Pull-Request: https://github.com/git/git/pull/1602
Range-diff vs v1:
 1:  e3ff8aa76fe ! 1:  dfb442ea338 chore: fix typo in .clang-format comment
     @@ Metadata
      Author: Aditya Neelamraju <adityanv97@gmail.com>
      
       ## Commit message ##
     -    chore: fix typo in .clang-format comment
     +    clang-format: fix typo in comment
      
          Signed-off-by: Aditya Neelamraju <adityanv97@gmail.com>
      
 .clang-format | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Show changes to .clang-format +3 −3
diff --git a/.clang-format b/.clang-format
index c592dda681f..3ed4fac753a 100644
--- a/.clang-format
+++ b/.clang-format
@@ -83,9 +83,9 @@ BinPackParameters: true
 BreakBeforeBraces: Linux
 
 # Break after operators
-# int valuve = aaaaaaaaaaaaa +
-#              bbbbbb -
-#              ccccccccccc;
+# int value = aaaaaaaaaaaaa +
+#             bbbbbb -
+#             ccccccccccc;
 BreakBeforeBinaryOperators: None
 BreakBeforeTernaryOperators: false
 

base-commit: 2e8e77cbac8ac17f94eee2087187fa1718e38b14
-- 
gitgitgadget
Taylor Blau· Oct 31, 2023, 19:09 UTC · re: Aditya Neelamraju via GitGitGadget · lore

Re: [PATCH v2] clang-format: fix typo in comment

On Tue, Oct 31, 2023 at 01:40:28PM +0000, Aditya Neelamraju via GitGitGadget wrote:
> From: Aditya Neelamraju <adityanv97@gmail.com>
>
> Signed-off-by: Aditya Neelamraju <adityanv97@gmail.com>
> ---
Thanks, this version looks great to me.

Thanks, Taylor

← back to recent threads