{"thread":{"id":"60443","subject":"[PATCH] chore: fix typo in .clang-format comment","startedAt":"2023-10-29T20:23:13Z","lastAt":"2023-10-31T23:40:40Z","messageCount":7,"participants":["Aditya Neelamraju via GitGitGadget","Taylor Blau","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"484055","messageId":"pull.1602.git.git.1698610987926.gitgitgadget@gmail.com","threadId":"60443","inReplyTo":null,"subject":"[PATCH] chore: fix typo in .clang-format comment","fromName":"Aditya Neelamraju via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2023-10-29T20:23:07Z","receivedAt":"2023-10-29T20:23:13Z","isPatch":true,"sender":{"key":"name:Aditya Neelamraju","avatar":null},"body":"From: Aditya Neelamraju \n\nSigned-off-by: Aditya Neelamraju \n---\n chore: fix typo in .clang-format comment\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1602%2Faneelamr%2Fclang-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1602/aneelamr/clang-v1\nPull-Request: https://github.com/git/git/pull/1602\n\n .clang-format | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/.clang-format b/.clang-format\nindex c592dda681f..3ed4fac753a 100644\n--- a/.clang-format\n+++ b/.clang-format\n@@ -83,9 +83,9 @@ BinPackParameters: true\n BreakBeforeBraces: Linux\n \n # Break after operators\n-# int valuve = aaaaaaaaaaaaa +\n-# bbbbbb -\n-# ccccccccccc;\n+# int value = aaaaaaaaaaaaa +\n+# bbbbbb -\n+# ccccccccccc;\n BreakBeforeBinaryOperators: None\n BreakBeforeTernaryOperators: false\n \n\nbase-commit: 2e8e77cbac8ac17f94eee2087187fa1718e38b14\n-- \ngitgitgadget\n"},{"id":"484128","messageId":"ZT/gQZlVKfgn/+BZ@nand.local","threadId":"60443","inReplyTo":"pull.1602.git.git.1698610987926.gitgitgadget@gmail.com","subject":"Re: [PATCH] chore: fix typo in .clang-format comment","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2023-10-30T16:56:33Z","receivedAt":"2023-10-30T16:56:36Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Sun, Oct 29, 2023 at 08:23:07PM +0000, Aditya Neelamraju via GitGitGadget wrote:\n> From: Aditya Neelamraju \n\nWe typically prefix commit messages with the subject area they're\nworking in, not with \"chore\", or \"feat\" like some Git workflows\nrecommend.\n\nThat said, the contents of this patch look obviously correct to me.\nThanks for noticing and fixing!\n\nThanks,\nTaylor\n"},{"id":"484176","messageId":"xmqqpm0v5vtg.fsf@gitster.g","threadId":"60443","inReplyTo":"ZT/gQZlVKfgn/+BZ@nand.local","subject":"Re: [PATCH] chore: fix typo in .clang-format comment","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2023-10-31T03:12:43Z","receivedAt":"2023-10-31T03:12:48Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Taylor Blau writes:\n\n> On Sun, Oct 29, 2023 at 08:23:07PM +0000, Aditya Neelamraju via GitGitGadget wrote:\n>> From: Aditya Neelamraju \n>\n> We typically prefix commit messages with the subject area they're\n> working in, not with \"chore\", or \"feat\" like some Git workflows\n> recommend.\n> ...\n> That said, the contents of this patch look obviously correct to me.\n> Thanks for noticing and fixing!\n\nAs a comment for a new contributor, it is a bit unhelpful not to\nsuggest what the \"subject area\" string we would use if we were\nworking on this patch, I think.\n\nI also suspected that valuve may be a valid word in some language,\nas the indentation in the example looked as if the six-letter word\nwas meant, not typoed. https://www.gasolineravaluve.com/ was one\nof the first hits I saw in my search ;-)\n\n"},{"id":"484237","messageId":"pull.1602.v2.git.git.1698759629166.gitgitgadget@gmail.com","threadId":"60443","inReplyTo":"pull.1602.git.git.1698610987926.gitgitgadget@gmail.com","subject":"[PATCH v2] clang-format: fix typo in comment","fromName":"Aditya Neelamraju via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2023-10-31T13:40:28Z","receivedAt":"2023-10-31T13:40:33Z","isPatch":true,"sender":{"key":"name:Aditya Neelamraju","avatar":null},"body":"From: Aditya Neelamraju \n\nSigned-off-by: Aditya Neelamraju \n---\n clang-format: fix typo in comment for formatting binary operations.\n \n cc: Taylor Blau me@ttaylorr.com\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1602%2Faneelamr%2Fclang-v2\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1602/aneelamr/clang-v2\nPull-Request: https://github.com/git/git/pull/1602\n\nRange-diff vs v1:\n\n 1: e3ff8aa76fe ! 1: dfb442ea338 chore: fix typo in .clang-format comment\n @@ Metadata\n Author: Aditya Neelamraju \n \n ## Commit message ##\n - chore: fix typo in .clang-format comment\n + clang-format: fix typo in comment\n \n Signed-off-by: Aditya Neelamraju \n \n\n\n .clang-format | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/.clang-format b/.clang-format\nindex c592dda681f..3ed4fac753a 100644\n--- a/.clang-format\n+++ b/.clang-format\n@@ -83,9 +83,9 @@ BinPackParameters: true\n BreakBeforeBraces: Linux\n \n # Break after operators\n-# int valuve = aaaaaaaaaaaaa +\n-# bbbbbb -\n-# ccccccccccc;\n+# int value = aaaaaaaaaaaaa +\n+# bbbbbb -\n+# ccccccccccc;\n BreakBeforeBinaryOperators: None\n BreakBeforeTernaryOperators: false\n \n\nbase-commit: 2e8e77cbac8ac17f94eee2087187fa1718e38b14\n-- \ngitgitgadget\n"},{"id":"484245","messageId":"ZUFQzFcgGdJsPJ8G@nand.local","threadId":"60443","inReplyTo":"xmqqpm0v5vtg.fsf@gitster.g","subject":"Re: [PATCH] chore: fix typo in .clang-format comment","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2023-10-31T19:09:00Z","receivedAt":"2023-10-31T19:09:03Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Tue, Oct 31, 2023 at 12:12:43PM +0900, Junio C Hamano wrote:\n> Taylor Blau writes:\n>\n> > On Sun, Oct 29, 2023 at 08:23:07PM +0000, Aditya Neelamraju via GitGitGadget wrote:\n> >> From: Aditya Neelamraju \n> >\n> > We typically prefix commit messages with the subject area they're\n> > working in, not with \"chore\", or \"feat\" like some Git workflows\n> > recommend.\n> > ...\n> > That said, the contents of this patch look obviously correct to me.\n> > Thanks for noticing and fixing!\n>\n> As a comment for a new contributor, it is a bit unhelpful not to\n> suggest what the \"subject area\" string we would use if we were\n> working on this patch, I think.\n\nGood suggestion. I would have suggested \"clang-format\", which is\nexactly Aditya ended up choosing, anyway. Thanks, Aditya!\n\n> I also suspected that valuve may be a valid word in some language,\n> as the indentation in the example looked as if the six-letter word\n> was meant, not typoed. https://www.gasolineravaluve.com/ was one\n> of the first hits I saw in my search ;-)\n\n;-)\n\nThanks,\nTaylor\n"},{"id":"484246","messageId":"ZUFQ2bvWu3qX6s/L@nand.local","threadId":"60443","inReplyTo":"pull.1602.v2.git.git.1698759629166.gitgitgadget@gmail.com","subject":"Re: [PATCH v2] clang-format: fix typo in comment","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2023-10-31T19:09:13Z","receivedAt":"2023-10-31T19:09:16Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Tue, Oct 31, 2023 at 01:40:28PM +0000, Aditya Neelamraju via GitGitGadget wrote:\n> From: Aditya Neelamraju \n>\n> Signed-off-by: Aditya Neelamraju \n> ---\n\nThanks, this version looks great to me.\n\nThanks,\nTaylor\n"},{"id":"484267","messageId":"xmqqbkce1hu3.fsf@gitster.g","threadId":"60443","inReplyTo":"ZUFQzFcgGdJsPJ8G@nand.local","subject":"Re: [PATCH] chore: fix typo in .clang-format comment","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2023-10-31T23:40:36Z","receivedAt":"2023-10-31T23:40:40Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Taylor Blau writes:\n\n>> As a comment for a new contributor, it is a bit unhelpful not to\n>> suggest what the \"subject area\" string we would use if we were\n>> working on this patch, I think.\n>\n> Good suggestion. I would have suggested \"clang-format\", which is\n> exactly Aditya ended up choosing, anyway. Thanks, Aditya!\n\nThanks. I was being lazy when I said the above ;-)\n\nTeaching how to fish instead of giving fish, the way I would have\ndone is\n\n $ git log --no-merges --stat --full-diff .clang-format\n\nand inspect what they use. The ones that used \"clang-format:\" are\nindeed very similar in spirit to what this one does, I would say.\n\nThanks.\n\n"}]}