# [PATCH] chore: fix typo in .clang-format comment 7 messages from 2023-10-29 to 2023-10-31. Participants: Aditya Neelamraju via GitGitGadget, Taylor Blau, Junio C Hamano. Thread: https://gitlist.dev/t/60443 ## Aditya Neelamraju via GitGitGadget, 2023-10-29 20:23 Subject: [PATCH] chore: fix typo in .clang-format comment Message-ID: URL: https://gitlist.dev/e/pull.1602.git.git.1698610987926.gitgitgadget%40gmail.com ``` From: Aditya Neelamraju Signed-off-by: Aditya Neelamraju --- chore: fix typo in .clang-format comment Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1602%2Faneelamr%2Fclang-v1 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1602/aneelamr/clang-v1 Pull-Request: https://github.com/git/git/pull/1602 .clang-format | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.clang-format b/.clang-format index c592dda681f..3ed4fac753a 100644 --- a/.clang-format +++ b/.clang-format @@ -83,9 +83,9 @@ BinPackParameters: true BreakBeforeBraces: Linux # Break after operators -# int valuve = aaaaaaaaaaaaa + -# bbbbbb - -# ccccccccccc; +# int value = aaaaaaaaaaaaa + +# bbbbbb - +# ccccccccccc; BreakBeforeBinaryOperators: None BreakBeforeTernaryOperators: false base-commit: 2e8e77cbac8ac17f94eee2087187fa1718e38b14 -- gitgitgadget ``` ## Taylor Blau, 2023-10-30 16:56 Subject: Re: [PATCH] chore: fix typo in .clang-format comment Message-ID: URL: https://gitlist.dev/e/ZT%2FgQZlVKfgn%2F%2BBZ%40nand.local In-Reply-To: ``` On Sun, Oct 29, 2023 at 08:23:07PM +0000, Aditya Neelamraju via GitGitGadget wrote: > From: Aditya Neelamraju We typically prefix commit messages with the subject area they're working in, not with "chore", or "feat" like some Git workflows recommend. That said, the contents of this patch look obviously correct to me. Thanks for noticing and fixing! Thanks, Taylor ``` ## Junio C Hamano, 2023-10-31 03:12 Subject: Re: [PATCH] chore: fix typo in .clang-format comment Message-ID: URL: https://gitlist.dev/e/xmqqpm0v5vtg.fsf%40gitster.g In-Reply-To: ``` Taylor Blau writes: > On Sun, Oct 29, 2023 at 08:23:07PM +0000, Aditya Neelamraju via GitGitGadget wrote: >> From: Aditya Neelamraju > > We typically prefix commit messages with the subject area they're > working in, not with "chore", or "feat" like some Git workflows > recommend. > ... > That said, the contents of this patch look obviously correct to me. > Thanks for noticing and fixing! As a comment for a new contributor, it is a bit unhelpful not to suggest what the "subject area" string we would use if we were working on this patch, I think. I also suspected that valuve may be a valid word in some language, as the indentation in the example looked as if the six-letter word was meant, not typoed. https://www.gasolineravaluve.com/ was one of the first hits I saw in my search ;-) ``` ## Aditya Neelamraju via GitGitGadget, 2023-10-31 13:40 Subject: [PATCH v2] clang-format: fix typo in comment Message-ID: URL: https://gitlist.dev/e/pull.1602.v2.git.git.1698759629166.gitgitgadget%40gmail.com In-Reply-To: ``` From: Aditya Neelamraju Signed-off-by: Aditya Neelamraju --- clang-format: fix typo in comment for formatting binary operations. cc: Taylor Blau me@ttaylorr.com Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1602%2Faneelamr%2Fclang-v2 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1602/aneelamr/clang-v2 Pull-Request: https://github.com/git/git/pull/1602 Range-diff vs v1: 1: e3ff8aa76fe ! 1: dfb442ea338 chore: fix typo in .clang-format comment @@ Metadata Author: Aditya Neelamraju ## Commit message ## - chore: fix typo in .clang-format comment + clang-format: fix typo in comment Signed-off-by: Aditya Neelamraju .clang-format | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.clang-format b/.clang-format index c592dda681f..3ed4fac753a 100644 --- a/.clang-format +++ b/.clang-format @@ -83,9 +83,9 @@ BinPackParameters: true BreakBeforeBraces: Linux # Break after operators -# int valuve = aaaaaaaaaaaaa + -# bbbbbb - -# ccccccccccc; +# int value = aaaaaaaaaaaaa + +# bbbbbb - +# ccccccccccc; BreakBeforeBinaryOperators: None BreakBeforeTernaryOperators: false base-commit: 2e8e77cbac8ac17f94eee2087187fa1718e38b14 -- gitgitgadget ``` ## Taylor Blau, 2023-10-31 19:09 Subject: Re: [PATCH] chore: fix typo in .clang-format comment Message-ID: URL: https://gitlist.dev/e/ZUFQzFcgGdJsPJ8G%40nand.local In-Reply-To: ``` On Tue, Oct 31, 2023 at 12:12:43PM +0900, Junio C Hamano wrote: > Taylor Blau writes: > > > On Sun, Oct 29, 2023 at 08:23:07PM +0000, Aditya Neelamraju via GitGitGadget wrote: > >> From: Aditya Neelamraju > > > > We typically prefix commit messages with the subject area they're > > working in, not with "chore", or "feat" like some Git workflows > > recommend. > > ... > > That said, the contents of this patch look obviously correct to me. > > Thanks for noticing and fixing! > > As a comment for a new contributor, it is a bit unhelpful not to > suggest what the "subject area" string we would use if we were > working on this patch, I think. Good suggestion. I would have suggested "clang-format", which is exactly Aditya ended up choosing, anyway. Thanks, Aditya! > I also suspected that valuve may be a valid word in some language, > as the indentation in the example looked as if the six-letter word > was meant, not typoed. https://www.gasolineravaluve.com/ was one > of the first hits I saw in my search ;-) ;-) Thanks, Taylor ``` ## Taylor Blau, 2023-10-31 19:09 Subject: Re: [PATCH v2] clang-format: fix typo in comment Message-ID: URL: https://gitlist.dev/e/ZUFQ2bvWu3qX6s%2FL%40nand.local In-Reply-To: ``` On Tue, Oct 31, 2023 at 01:40:28PM +0000, Aditya Neelamraju via GitGitGadget wrote: > From: Aditya Neelamraju > > Signed-off-by: Aditya Neelamraju > --- Thanks, this version looks great to me. Thanks, Taylor ``` ## Junio C Hamano, 2023-10-31 23:40 Subject: Re: [PATCH] chore: fix typo in .clang-format comment Message-ID: URL: https://gitlist.dev/e/xmqqbkce1hu3.fsf%40gitster.g In-Reply-To: ``` Taylor Blau writes: >> As a comment for a new contributor, it is a bit unhelpful not to >> suggest what the "subject area" string we would use if we were >> working on this patch, I think. > > Good suggestion. I would have suggested "clang-format", which is > exactly Aditya ended up choosing, anyway. Thanks, Aditya! Thanks. I was being lazy when I said the above ;-) Teaching how to fish instead of giving fish, the way I would have done is $ git log --no-merges --stat --full-diff .clang-format and inspect what they use. The ones that used "clang-format:" are indeed very similar in spirit to what this one does, I would say. Thanks. ```