git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] chore: fix typo in .clang-format comment

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 31, 2023, 03:12 UTC
Message-ID
<xmqqpm0v5vtg.fsf@gitster.g>
In-Reply-To
<ZT/gQZlVKfgn/+BZ@nand.local>
Taylor Blau <me@ttaylorr.com> writes:
Show 9 quoted lines
> On Sun, Oct 29, 2023 at 08:23:07PM +0000, Aditya Neelamraju via GitGitGadget wrote:
>> From: Aditya Neelamraju <adityanv97@gmail.com>
>
> We typically prefix commit messages with the subject area they're
> working in, not with "chore", or "feat" like some Git workflows
> recommend.
> ...
> That said, the contents of this patch look obviously correct to me.
> Thanks for noticing and fixing!

As a comment for a new contributor, it is a bit unhelpful not to suggest what the "subject area" string we would use if we were working on this patch, I think.

I also suspected that valuve may be a valid word in some language, as the indentation in the example looked as if the six-letter word was meant, not typoed. https://www.gasolineravaluve.com/ was one of the first hits I saw in my search ;-)

Previous: Taylor BlauNext: Taylor Blau
Message 3 of 7 in “chore: fix typo in .clang-format comment”
  1. chore: fix typo in .clang-format commentAditya Neelamraju via GitGitGadget, Oct 29, 2023
  2. Taylor BlauOct 30, 2023
  3. Junio C HamanoOct 31, 2023
  4. Taylor BlauOct 31, 2023
  5. Junio C HamanoOct 31, 2023
  6. clang-format: fix typo in commentAditya Neelamraju via GitGitGadget, Oct 31, 2023
  7. Taylor BlauOct 31, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.