threads / patch / 5835

patchgitweb: [commit view] Do not suppress commitdiff link in root commit

Subject: [PATCH] gitweb: [commit view] Do not suppress commitdiff link in root commit

## tl;dr

5 messages between Oct 6, 2006 and Oct 7, 2006. Diffs are folded; open one to read it.

replies: 4people: 3as markdown or json

Petr Baudis· Oct 6, 2006, 16:59 UTC · lore

There's no reason for that, the commitdiff view is meaningful for the root commit as well and we link to it everywhere else.

Signed-off-by: Petr Baudis <pasky@suse.cz>
---
 gitweb/gitweb.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to gitweb/gitweb.perl +1 −1
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 56e5231..3a10124 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -3034,7 +3034,7 @@ sub git_commit {
 			$cgi->a({-href => href(action=>"log", hash=>$hash)}, "log");
 	}
 	git_header_html(undef, $expires);
-	git_print_page_nav('commit', defined $co{'parent'} ? '' : 'commitdiff',
+	git_print_page_nav('commit', '',
 	                   $hash, $co{'tree'}, $hash,
 	                   join (' | ', @views_nav));
Jakub Narebski· Oct 6, 2006, 20:57 UTC · re: Petr Baudis · lore

Re: [PATCH] gitweb: [commit view] Do not suppress commitdiff link in root commit

Petr Baudis wrote:
> There's no reason for that, the commitdiff view is meaningful for the
> root commit as well and we link to it everywhere else.

It not used to be. It is since we added '--root' as hash_parent ('hp') parameter for parentless commits.

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
Junio C Hamano· Oct 7, 2006, 07:25 UTC · re: Petr Baudis · lore

Re: [PATCH] gitweb: [commit view] Do not suppress commitdiff link in root commit

Petr Baudis <pasky@suse.cz> writes:
> There's no reason for that, the commitdiff view is meaningful for the
> root commit as well and we link to it everywhere else.

It probably is not any more useful than the blob view but I agree there is no strong reason to supress it, as long as the commitdiff page is prepared to show the root commit (which I haven't checked -- if you have --root you should be Ok).

Jakub Narebski· Oct 7, 2006, 10:00 UTC · re: Junio C Hamano · lore

Re: [PATCH] gitweb: [commit view] Do not suppress commitdiff link in root commit

Junio C Hamano wrote:
Show 9 quoted lines
> Petr Baudis <pasky@suse.cz> writes:
> 
>> There's no reason for that, the commitdiff view is meaningful for the
>> root commit as well and we link to it everywhere else.
> 
> It probably is not any more useful than the blob view but I
> agree there is no strong reason to supress it, as long as the
> commitdiff page is prepared to show the root commit (which I
> haven't checked -- if you have --root you should be Ok).

The commitdiff for root commit is much less useful, I think, and not having commitdiff link serves as indicator of root (parentless) commit, important in non-commit views. 

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
Petr Baudis· Oct 7, 2006, 12:33 UTC · re: Jakub Narebski · lore

Re: [PATCH] gitweb: [commit view] Do not suppress commitdiff link in root commit

Dear diary, on Sat, Oct 07, 2006 at 12:00:29PM CEST, I got a letter where Jakub Narebski <jnareb@gmail.com> said that...

Show 15 quoted lines
> Junio C Hamano wrote:
> 
> > Petr Baudis <pasky@suse.cz> writes:
> > 
> >> There's no reason for that, the commitdiff view is meaningful for the
> >> root commit as well and we link to it everywhere else.
> > 
> > It probably is not any more useful than the blob view but I
> > agree there is no strong reason to supress it, as long as the
> > commitdiff page is prepared to show the root commit (which I
> > haven't checked -- if you have --root you should be Ok).
> 
> The commitdiff for root commit is much less useful, I think, and not having
> commitdiff link serves as indicator of root (parentless) commit, important
> in non-commit views. 
  But we don't shor commitdiff _only_ (afaics) in the commit view. ;-)
So it doesn't indicate anything anyway.
  I personally don't mind looking at mass-addition patches (something
looking at Debian package diffs teaches you), and it's a quick way to
see all the files being added to the tree, not browse them blob-by-blob.
-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
#!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj
$/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1
lK[d2%Sa2/d0$^Ixp"|dc`;s/\W//g;$_=pack('H*',/((..)*)$/)

← back to recent threads