{"thread":{"id":"5835","subject":"[PATCH] gitweb: [commit view] Do not suppress commitdiff link in root commit","startedAt":"2006-10-06T16:59:33Z","lastAt":"2006-10-07T12:33:44Z","messageCount":5,"participants":["Petr Baudis","Jakub Narebski","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"28305","messageId":"20061006165933.4127.72491.stgit@rover","threadId":"5835","inReplyTo":null,"subject":"[PATCH] gitweb: [commit view] Do not suppress commitdiff link in root commit","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2006-10-06T16:59:33Z","receivedAt":"2006-10-06T16:59:33Z","isPatch":true,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"There's no reason for that, the commitdiff view is meaningful for the\nroot commit as well and we link to it everywhere else.\n\nSigned-off-by: Petr Baudis \n---\n\n gitweb/gitweb.perl | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 56e5231..3a10124 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -3034,7 +3034,7 @@ sub git_commit {\n \t\t\t$cgi->a({-href => href(action=>\"log\", hash=>$hash)}, \"log\");\n \t}\n \tgit_header_html(undef, $expires);\n-\tgit_print_page_nav('commit', defined $co{'parent'} ? '' : 'commitdiff',\n+\tgit_print_page_nav('commit', '',\n \t $hash, $co{'tree'}, $hash,\n \t join (' | ', @views_nav));\n \n"},{"id":"28328","messageId":"eg6fti$ffc$1@sea.gmane.org","threadId":"5835","inReplyTo":"20061006165933.4127.72491.stgit@rover","subject":"Re: [PATCH] gitweb: [commit view] Do not suppress commitdiff link in root commit","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-10-06T20:57:05Z","receivedAt":"2006-10-06T20:57:05Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Petr Baudis wrote:\n\n> There's no reason for that, the commitdiff view is meaningful for the\n> root commit as well and we link to it everywhere else.\n\nIt not used to be. It is since we added '--root' as hash_parent ('hp')\nparameter for parentless commits.\n-- \nJakub Narebski\nWarsaw, Poland\nShadeHawk on #git\n"},{"id":"28340","messageId":"7vmz88ziwv.fsf@assigned-by-dhcp.cox.net","threadId":"5835","inReplyTo":"20061006165933.4127.72491.stgit@rover","subject":"Re: [PATCH] gitweb: [commit view] Do not suppress commitdiff link in root commit","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-10-07T07:25:52Z","receivedAt":"2006-10-07T07:25:52Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Petr Baudis writes:\n\n> There's no reason for that, the commitdiff view is meaningful for the\n> root commit as well and we link to it everywhere else.\n\nIt probably is not any more useful than the blob view but I\nagree there is no strong reason to supress it, as long as the\ncommitdiff page is prepared to show the root commit (which I\nhaven't checked -- if you have --root you should be Ok).\n"},{"id":"28351","messageId":"eg7tqd$lie$1@sea.gmane.org","threadId":"5835","inReplyTo":"7vmz88ziwv.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] gitweb: [commit view] Do not suppress commitdiff link in root commit","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-10-07T10:00:29Z","receivedAt":"2006-10-07T10:00:29Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Junio C Hamano wrote:\n\n> Petr Baudis writes:\n> \n>> There's no reason for that, the commitdiff view is meaningful for the\n>> root commit as well and we link to it everywhere else.\n> \n> It probably is not any more useful than the blob view but I\n> agree there is no strong reason to supress it, as long as the\n> commitdiff page is prepared to show the root commit (which I\n> haven't checked -- if you have --root you should be Ok).\n\nThe commitdiff for root commit is much less useful, I think, and not having\ncommitdiff link serves as indicator of root (parentless) commit, important\nin non-commit views. \n\n-- \nJakub Narebski\nWarsaw, Poland\nShadeHawk on #git\n"},{"id":"28362","messageId":"20061007123344.GZ20017@pasky.or.cz","threadId":"5835","inReplyTo":"eg7tqd$lie$1@sea.gmane.org","subject":"Re: [PATCH] gitweb: [commit view] Do not suppress commitdiff link in root commit","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2006-10-07T12:33:44Z","receivedAt":"2006-10-07T12:33:44Z","isPatch":true,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"Dear diary, on Sat, Oct 07, 2006 at 12:00:29PM CEST, I got a letter\nwhere Jakub Narebski said that...\n> Junio C Hamano wrote:\n> \n> > Petr Baudis writes:\n> > \n> >> There's no reason for that, the commitdiff view is meaningful for the\n> >> root commit as well and we link to it everywhere else.\n> > \n> > It probably is not any more useful than the blob view but I\n> > agree there is no strong reason to supress it, as long as the\n> > commitdiff page is prepared to show the root commit (which I\n> > haven't checked -- if you have --root you should be Ok).\n> \n> The commitdiff for root commit is much less useful, I think, and not having\n> commitdiff link serves as indicator of root (parentless) commit, important\n> in non-commit views. \n\n But we don't shor commitdiff _only_ (afaics) in the commit view. ;-)\nSo it doesn't indicate anything anyway.\n\n I personally don't mind looking at mass-addition patches (something\nlooking at Debian package diffs teaches you), and it's a quick way to\nsee all the files being added to the tree, not browse them blob-by-blob.\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nStuff: http://pasky.or.cz/\n#!/bin/perl -sp0777i