# [PATCH] gitweb: [commit view] Do not suppress commitdiff link in root commit 5 messages from 2006-10-06 to 2006-10-07. Participants: Petr Baudis, Jakub Narebski, Junio C Hamano. Thread: https://gitlist.dev/t/5835 ## Petr Baudis, 2006-10-06 16:59 Subject: [PATCH] gitweb: [commit view] Do not suppress commitdiff link in root commit Message-ID: <20061006165933.4127.72491.stgit@rover> URL: https://gitlist.dev/e/20061006165933.4127.72491.stgit%40rover ``` There's no reason for that, the commitdiff view is meaningful for the root commit as well and we link to it everywhere else. Signed-off-by: Petr Baudis --- gitweb/gitweb.perl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 56e5231..3a10124 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -3034,7 +3034,7 @@ sub git_commit { $cgi->a({-href => href(action=>"log", hash=>$hash)}, "log"); } git_header_html(undef, $expires); - git_print_page_nav('commit', defined $co{'parent'} ? '' : 'commitdiff', + git_print_page_nav('commit', '', $hash, $co{'tree'}, $hash, join (' | ', @views_nav)); ``` ## Jakub Narebski, 2006-10-06 20:57 Subject: Re: [PATCH] gitweb: [commit view] Do not suppress commitdiff link in root commit Message-ID: URL: https://gitlist.dev/e/eg6fti%24ffc%241%40sea.gmane.org In-Reply-To: <20061006165933.4127.72491.stgit@rover> ``` Petr Baudis wrote: > There's no reason for that, the commitdiff view is meaningful for the > root commit as well and we link to it everywhere else. It not used to be. It is since we added '--root' as hash_parent ('hp') parameter for parentless commits. -- Jakub Narebski Warsaw, Poland ShadeHawk on #git ``` ## Junio C Hamano, 2006-10-07 07:25 Subject: Re: [PATCH] gitweb: [commit view] Do not suppress commitdiff link in root commit Message-ID: <7vmz88ziwv.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7vmz88ziwv.fsf%40assigned-by-dhcp.cox.net In-Reply-To: <20061006165933.4127.72491.stgit@rover> ``` Petr Baudis writes: > There's no reason for that, the commitdiff view is meaningful for the > root commit as well and we link to it everywhere else. It probably is not any more useful than the blob view but I agree there is no strong reason to supress it, as long as the commitdiff page is prepared to show the root commit (which I haven't checked -- if you have --root you should be Ok). ``` ## Jakub Narebski, 2006-10-07 10:00 Subject: Re: [PATCH] gitweb: [commit view] Do not suppress commitdiff link in root commit Message-ID: URL: https://gitlist.dev/e/eg7tqd%24lie%241%40sea.gmane.org In-Reply-To: <7vmz88ziwv.fsf@assigned-by-dhcp.cox.net> ``` Junio C Hamano wrote: > Petr Baudis writes: > >> There's no reason for that, the commitdiff view is meaningful for the >> root commit as well and we link to it everywhere else. > > It probably is not any more useful than the blob view but I > agree there is no strong reason to supress it, as long as the > commitdiff page is prepared to show the root commit (which I > haven't checked -- if you have --root you should be Ok). The commitdiff for root commit is much less useful, I think, and not having commitdiff link serves as indicator of root (parentless) commit, important in non-commit views. -- Jakub Narebski Warsaw, Poland ShadeHawk on #git ``` ## Petr Baudis, 2006-10-07 12:33 Subject: Re: [PATCH] gitweb: [commit view] Do not suppress commitdiff link in root commit Message-ID: <20061007123344.GZ20017@pasky.or.cz> URL: https://gitlist.dev/e/20061007123344.GZ20017%40pasky.or.cz In-Reply-To: ``` Dear diary, on Sat, Oct 07, 2006 at 12:00:29PM CEST, I got a letter where Jakub Narebski said that... > Junio C Hamano wrote: > > > Petr Baudis writes: > > > >> There's no reason for that, the commitdiff view is meaningful for the > >> root commit as well and we link to it everywhere else. > > > > It probably is not any more useful than the blob view but I > > agree there is no strong reason to supress it, as long as the > > commitdiff page is prepared to show the root commit (which I > > haven't checked -- if you have --root you should be Ok). > > The commitdiff for root commit is much less useful, I think, and not having > commitdiff link serves as indicator of root (parentless) commit, important > in non-commit views. But we don't shor commitdiff _only_ (afaics) in the commit view. ;-) So it doesn't indicate anything anyway. I personally don't mind looking at mass-addition patches (something looking at Debian package diffs teaches you), and it's a quick way to see all the files being added to the tree, not browse them blob-by-blob. -- Petr "Pasky" Baudis Stuff: http://pasky.or.cz/ #!/bin/perl -sp0777i