Re: [PATCH] gitweb: [commit view] Do not suppress commitdiff link in root commit

From: Petr Baudis <pasky@suse.cz>
Date: Oct 7, 2006, 12:33 UTC
Message-ID: <20061007123344.GZ20017@pasky.or.cz>
In-Reply-To: <eg7tqd$lie$1@sea.gmane.org>

Dear diary, on Sat, Oct 07, 2006 at 12:00:29PM CEST, I got a letter where Jakub Narebski <jnareb@gmail.com> said that...

Show 15 quoted lines

> Junio C Hamano wrote:
> 
> > Petr Baudis <pasky@suse.cz> writes:
> > 
> >> There's no reason for that, the commitdiff view is meaningful for the
> >> root commit as well and we link to it everywhere else.
> > 
> > It probably is not any more useful than the blob view but I
> > agree there is no strong reason to supress it, as long as the
> > commitdiff page is prepared to show the root commit (which I
> > haven't checked -- if you have --root you should be Ok).
> 
> The commitdiff for root commit is much less useful, I think, and not having
> commitdiff link serves as indicator of root (parentless) commit, important
> in non-commit views.

  But we don't shor commitdiff _only_ (afaics) in the commit view. ;-)
So it doesn't indicate anything anyway.

  I personally don't mind looking at mass-addition patches (something
looking at Debian package diffs teaches you), and it's a quick way to
see all the files being added to the tree, not browse them blob-by-blob.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
#!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj
$/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1
lK[d2%Sa2/d0$^Ixp"|dc`;s/\W//g;$_=pack('H*',/((..)*)$/)