threads / patch / 57977

patchsetup: fix function name

Subject: [PATCH] setup: fix function name

## tl;dr

2 messages between Jun 9, 2022 and Jun 17, 2022. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Cleber Rosa via GitGitGadget· Jun 9, 2022, 13:55 UTC · lore

From: Cleber Rosa <crosa@redhat.com>

The reference given to users when the result of setup_git_directory_gently_1() is unexpected is incorrect.

This fixes the name of the function when presenting the BUG message.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
---
    setup: fix function name

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1255%2Fclebergnu%2Ffix_function_name-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1255/clebergnu/fix_function_name-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1255

 setup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to setup.c +1 −1

diff --git a/setup.c b/setup.c
index faf5095e44d..b5a537258d2 100644
--- a/setup.c
+++ b/setup.c
@@ -1402,7 +1402,7 @@ const char *setup_git_directory_gently(int *nongit_ok)
 		 * find a repository.
 		 */
 	default:
-		BUG("unhandled setup_git_directory_1() result");
+		BUG("unhandled setup_git_directory_gently_1() result");
 	}
 
 	/*

base-commit: 9c897eef06347cc5a3eb07c3ae409970ab1052c8

-- 
gitgitgadget

Junio C Hamano· Jun 17, 2022, 22:43 UTC · re: Cleber Rosa via GitGitGadget · lore

Re: [PATCH] setup: fix function name

"Cleber Rosa via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Cleber Rosa <crosa@redhat.com>
> Subject: Re: [PATCH] setup: fix function name

I'd add "in a BUG() message" at the end.

Show 11 quoted lines

> diff --git a/setup.c b/setup.c
> index faf5095e44d..b5a537258d2 100644
> --- a/setup.c
> +++ b/setup.c
> @@ -1402,7 +1402,7 @@ const char *setup_git_directory_gently(int *nongit_ok)
>  		 * find a repository.
>  		 */
>  	default:
> -		BUG("unhandled setup_git_directory_1() result");
> +		BUG("unhandled setup_git_directory_gently_1() result");
>  	}

Did you actually hit this BUG() and was sent to a wild goose chase because of this typo? Just checking, because BUG() that triggers is a more serious issue itself.

Thanks.