Re: [PATCH] setup: fix function name

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 17, 2022, 22:43 UTC
Message-ID: <xmqqzgianc66.fsf@gitster.g>
In-Reply-To: <pull.1255.git.1654782920256.gitgitgadget@gmail.com>

"Cleber Rosa via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Cleber Rosa <crosa@redhat.com>
> Subject: Re: [PATCH] setup: fix function name

I'd add "in a BUG() message" at the end.

Show 11 quoted lines

> diff --git a/setup.c b/setup.c
> index faf5095e44d..b5a537258d2 100644
> --- a/setup.c
> +++ b/setup.c
> @@ -1402,7 +1402,7 @@ const char *setup_git_directory_gently(int *nongit_ok)
>  		 * find a repository.
>  		 */
>  	default:
> -		BUG("unhandled setup_git_directory_1() result");
> +		BUG("unhandled setup_git_directory_gently_1() result");
>  	}

Did you actually hit this BUG() and was sent to a wild goose chase because of this typo? Just checking, because BUG() that triggers is a more serious issue itself.

Thanks.