{"thread":{"id":"57977","subject":"[PATCH] setup: fix function name","startedAt":"2022-06-09T13:55:38Z","lastAt":"2022-06-17T22:43:54Z","messageCount":2,"participants":["Cleber Rosa via GitGitGadget","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"456941","messageId":"pull.1255.git.1654782920256.gitgitgadget@gmail.com","threadId":"57977","inReplyTo":null,"subject":"[PATCH] setup: fix function name","fromName":"Cleber Rosa via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2022-06-09T13:55:20Z","receivedAt":"2022-06-09T13:55:38Z","isPatch":true,"sender":{"key":"name:Cleber Rosa","avatar":null},"body":"From: Cleber Rosa <crosa@redhat.com>\n\nThe reference given to users when the result of\nsetup_git_directory_gently_1() is unexpected is incorrect.\n\nThis fixes the name of the function when presenting the BUG message.\n\nSigned-off-by: Cleber Rosa <crosa@redhat.com>\n---\n    setup: fix function name\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-1255%2Fclebergnu%2Ffix_function_name-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1255/clebergnu/fix_function_name-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/1255\n\n setup.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/setup.c b/setup.c\nindex faf5095e44d..b5a537258d2 100644\n--- a/setup.c\n+++ b/setup.c\n@@ -1402,7 +1402,7 @@ const char *setup_git_directory_gently(int *nongit_ok)\n \t\t * find a repository.\n \t\t */\n \tdefault:\n-\t\tBUG(\"unhandled setup_git_directory_1() result\");\n+\t\tBUG(\"unhandled setup_git_directory_gently_1() result\");\n \t}\n \n \t/*\n\nbase-commit: 9c897eef06347cc5a3eb07c3ae409970ab1052c8\n-- \ngitgitgadget\n"},{"id":"457466","messageId":"xmqqzgianc66.fsf@gitster.g","threadId":"57977","inReplyTo":"pull.1255.git.1654782920256.gitgitgadget@gmail.com","subject":"Re: [PATCH] setup: fix function name","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2022-06-17T22:43:45Z","receivedAt":"2022-06-17T22:43:54Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Cleber Rosa via GitGitGadget\" <gitgitgadget@gmail.com> writes:\n\n> From: Cleber Rosa <crosa@redhat.com>\n> Subject: Re: [PATCH] setup: fix function name\n\nI'd add \"in a BUG() message\" at the end.\n\n> diff --git a/setup.c b/setup.c\n> index faf5095e44d..b5a537258d2 100644\n> --- a/setup.c\n> +++ b/setup.c\n> @@ -1402,7 +1402,7 @@ const char *setup_git_directory_gently(int *nongit_ok)\n>  \t\t * find a repository.\n>  \t\t */\n>  \tdefault:\n> -\t\tBUG(\"unhandled setup_git_directory_1() result\");\n> +\t\tBUG(\"unhandled setup_git_directory_gently_1() result\");\n>  \t}\n\nDid you actually hit this BUG() and was sent to a wild goose chase\nbecause of this typo?  Just checking, because BUG() that triggers\nis a more serious issue itself.\n\nThanks.\n"}]}