# [PATCH] setup: fix function name 2 messages from 2022-06-09 to 2022-06-17. Participants: Cleber Rosa via GitGitGadget, Junio C Hamano. Thread: https://gitlist.dev/t/57977 ## Cleber Rosa via GitGitGadget, 2022-06-09 13:55 Subject: [PATCH] setup: fix function name Message-ID: URL: https://gitlist.dev/e/pull.1255.git.1654782920256.gitgitgadget%40gmail.com ``` From: Cleber Rosa The reference given to users when the result of setup_git_directory_gently_1() is unexpected is incorrect. This fixes the name of the function when presenting the BUG message. Signed-off-by: Cleber Rosa --- setup: fix function name Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1255%2Fclebergnu%2Ffix_function_name-v1 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1255/clebergnu/fix_function_name-v1 Pull-Request: https://github.com/gitgitgadget/git/pull/1255 setup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.c b/setup.c index faf5095e44d..b5a537258d2 100644 --- a/setup.c +++ b/setup.c @@ -1402,7 +1402,7 @@ const char *setup_git_directory_gently(int *nongit_ok) * find a repository. */ default: - BUG("unhandled setup_git_directory_1() result"); + BUG("unhandled setup_git_directory_gently_1() result"); } /* base-commit: 9c897eef06347cc5a3eb07c3ae409970ab1052c8 -- gitgitgadget ``` ## Junio C Hamano, 2022-06-17 22:43 Subject: Re: [PATCH] setup: fix function name Message-ID: URL: https://gitlist.dev/e/xmqqzgianc66.fsf%40gitster.g In-Reply-To: ``` "Cleber Rosa via GitGitGadget" writes: > From: Cleber Rosa > Subject: Re: [PATCH] setup: fix function name I'd add "in a BUG() message" at the end. > diff --git a/setup.c b/setup.c > index faf5095e44d..b5a537258d2 100644 > --- a/setup.c > +++ b/setup.c > @@ -1402,7 +1402,7 @@ const char *setup_git_directory_gently(int *nongit_ok) > * find a repository. > */ > default: > - BUG("unhandled setup_git_directory_1() result"); > + BUG("unhandled setup_git_directory_gently_1() result"); > } Did you actually hit this BUG() and was sent to a wild goose chase because of this typo? Just checking, because BUG() that triggers is a more serious issue itself. Thanks. ```