Re: [OUTREACHY] [PATCH v2] t0000: replace test -f with helper function
caleb.tillman@gmail.com writes:
> From: Caleb Tillman <caleb.tillman@gmail.com>
>
> Signed-off-by: Caleb Tillman <caleb.tillman@gmail.com>
> ---
Thanks. Let's declare victory and move on. You've demonstrated through the microproject that you can now comfortably be involved in the review discussion.
I'll keep the copy I queued on the 20th, though, with this title
t0000: use test_path_is_file instead of "test -f"
which is only slightly longer but is much more descriptive than this round.
Thanks.
Show 16 quoted lines
> t/t0000-basic.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh
> index 923281af93..eb99892a87 100755
> --- a/t/t0000-basic.sh
> +++ b/t/t0000-basic.sh
> @@ -1191,7 +1191,7 @@ test_expect_success 'writing this tree with --missing-ok' '
> test_expect_success 'git read-tree followed by write-tree should be idempotent' '
> rm -f .git/index &&
> git read-tree $tree &&
> - test -f .git/index &&
> + test_path_is_file .git/index &&
> newtree=$(git write-tree) &&
> test "$newtree" = "$tree"
> '
