git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[OUTREACHY] [PATCH v2] t0000: replace test -f with helper function

From
Ccaleb.tillman@gmail.com <caleb.tillman@gmail.com>
Date
Oct 20, 2020, 17:32 UTC
Message-ID
<20201020173257.80525-1-caleb.tillman@gmail.com>
From: Caleb Tillman <caleb.tillman@gmail.com>
Signed-off-by: Caleb Tillman <caleb.tillman@gmail.com>
---
 t/t0000-basic.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh
index 923281af93..eb99892a87 100755
--- a/t/t0000-basic.sh
+++ b/t/t0000-basic.sh
@@ -1191,7 +1191,7 @@ test_expect_success 'writing this tree with --missing-ok' '
 test_expect_success 'git read-tree followed by write-tree should be idempotent' '
 	rm -f .git/index &&
 	git read-tree $tree &&
-	test -f .git/index &&
+	test_path_is_file .git/index &&
 	newtree=$(git write-tree) &&
 	test "$newtree" = "$tree"
 '
-- 
2.25.1
Next: Junio C Hamano
Message 1 of 2 in “t0000: replace test -f with helper function”
  1. caleb.tillman@gmail.comOct 20, 2020
  2. Junio C HamanoOct 20, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.