# [OUTREACHY] [PATCH v2] t0000: replace test -f with helper function 2 messages from 2020-10-20 to 2020-10-20. Participants: caleb.tillman@gmail.com, Junio C Hamano. Thread: https://gitlist.dev/t/54471 ## caleb.tillman@gmail.com, 2020-10-20 17:32 Subject: [OUTREACHY] [PATCH v2] t0000: replace test -f with helper function Message-ID: <20201020173257.80525-1-caleb.tillman@gmail.com> URL: https://gitlist.dev/e/20201020173257.80525-1-caleb.tillman%40gmail.com ``` From: Caleb Tillman Signed-off-by: Caleb Tillman --- t/t0000-basic.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh index 923281af93..eb99892a87 100755 --- a/t/t0000-basic.sh +++ b/t/t0000-basic.sh @@ -1191,7 +1191,7 @@ test_expect_success 'writing this tree with --missing-ok' ' test_expect_success 'git read-tree followed by write-tree should be idempotent' ' rm -f .git/index && git read-tree $tree && - test -f .git/index && + test_path_is_file .git/index && newtree=$(git write-tree) && test "$newtree" = "$tree" ' -- 2.25.1 ``` ## Junio C Hamano, 2020-10-20 19:25 Subject: Re: [OUTREACHY] [PATCH v2] t0000: replace test -f with helper function Message-ID: URL: https://gitlist.dev/e/xmqqimb4bsxl.fsf%40gitster.c.googlers.com In-Reply-To: <20201020173257.80525-1-caleb.tillman@gmail.com> ``` caleb.tillman@gmail.com writes: > From: Caleb Tillman > > Signed-off-by: Caleb Tillman > --- Thanks. Let's declare victory and move on. You've demonstrated through the microproject that you can now comfortably be involved in the review discussion. I'll keep the copy I queued on the 20th, though, with this title t0000: use test_path_is_file instead of "test -f" which is only slightly longer but is much more descriptive than this round. Thanks. > t/t0000-basic.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh > index 923281af93..eb99892a87 100755 > --- a/t/t0000-basic.sh > +++ b/t/t0000-basic.sh > @@ -1191,7 +1191,7 @@ test_expect_success 'writing this tree with --missing-ok' ' > test_expect_success 'git read-tree followed by write-tree should be idempotent' ' > rm -f .git/index && > git read-tree $tree && > - test -f .git/index && > + test_path_is_file .git/index && > newtree=$(git write-tree) && > test "$newtree" = "$tree" > ' ```