{"thread":{"id":"54471","subject":"[OUTREACHY] [PATCH v2] t0000: replace test -f with helper function","startedAt":"2020-10-20T17:33:23Z","lastAt":"2020-10-20T19:26:07Z","messageCount":2,"participants":["caleb.tillman@gmail.com","Junio C Hamano"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"407993","messageId":"20201020173257.80525-1-caleb.tillman@gmail.com","threadId":"54471","inReplyTo":null,"subject":"[OUTREACHY] [PATCH v2] t0000: replace test -f with helper function","fromName":"","fromEmail":"caleb.tillman@gmail.com","sentAt":"2020-10-20T17:32:57Z","receivedAt":"2020-10-20T17:33:23Z","isPatch":true,"sender":{"key":"caleb.tillman@gmail.com","avatar":null},"body":"From: Caleb Tillman <caleb.tillman@gmail.com>\n\nSigned-off-by: Caleb Tillman <caleb.tillman@gmail.com>\n---\n t/t0000-basic.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t0000-basic.sh b/t/t0000-basic.sh\nindex 923281af93..eb99892a87 100755\n--- a/t/t0000-basic.sh\n+++ b/t/t0000-basic.sh\n@@ -1191,7 +1191,7 @@ test_expect_success 'writing this tree with --missing-ok' '\n test_expect_success 'git read-tree followed by write-tree should be idempotent' '\n \trm -f .git/index &&\n \tgit read-tree $tree &&\n-\ttest -f .git/index &&\n+\ttest_path_is_file .git/index &&\n \tnewtree=$(git write-tree) &&\n \ttest \"$newtree\" = \"$tree\"\n '\n-- \n2.25.1\n\n"},{"id":"408001","messageId":"xmqqimb4bsxl.fsf@gitster.c.googlers.com","threadId":"54471","inReplyTo":"20201020173257.80525-1-caleb.tillman@gmail.com","subject":"Re: [OUTREACHY] [PATCH v2] t0000: replace test -f with helper function","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2020-10-20T19:25:58Z","receivedAt":"2020-10-20T19:26:07Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"caleb.tillman@gmail.com writes:\n\n> From: Caleb Tillman <caleb.tillman@gmail.com>\n>\n> Signed-off-by: Caleb Tillman <caleb.tillman@gmail.com>\n> ---\n\nThanks.  Let's declare victory and move on.  You've demonstrated\nthrough the microproject that you can now comfortably be involved in\nthe review discussion.\n\nI'll keep the copy I queued on the 20th, though, with this title\n\n    t0000: use test_path_is_file instead of \"test -f\"\n\nwhich is only slightly longer but is much more descriptive than this\nround.\n\nThanks.\n\n>  t/t0000-basic.sh | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh\n> index 923281af93..eb99892a87 100755\n> --- a/t/t0000-basic.sh\n> +++ b/t/t0000-basic.sh\n> @@ -1191,7 +1191,7 @@ test_expect_success 'writing this tree with --missing-ok' '\n>  test_expect_success 'git read-tree followed by write-tree should be idempotent' '\n>  \trm -f .git/index &&\n>  \tgit read-tree $tree &&\n> -\ttest -f .git/index &&\n> +\ttest_path_is_file .git/index &&\n>  \tnewtree=$(git write-tree) &&\n>  \ttest \"$newtree\" = \"$tree\"\n>  '\n"}]}