threads / patch / 52257

patchcontrib: Add --recursive flag for bash completion

Subject: [PATCH 1/1] contrib: Add --recursive flag for bash completion

## tl;dr

4 messages between Nov 13, 2019 and Nov 13, 2019. Diffs are folded; open one to read it.

replies: 3people: 3as markdown or json

James via GitGitGadget· Nov 13, 2019, 00:47 UTC · lore

[PATCH 0/1] contrib: Add --recursive flag for bash completion

This flag was missing from the list, and I use it quite often :)

Signed-off-by: James Shubin james@shubin.ca [james@shubin.ca]

Thanks for taking the time to contribute to Git! Please be advised that the Git community does not use github.com for their contributions. Instead, we use a mailing list (git@vger.kernel.org) for code submissions, code reviews, and bug reports. Nevertheless, you can use GitGitGadget ( https://gitgitgadget.github.io/) to conveniently send your Pull Requests commits to our mailing list.

Please read the "guidelines for contributing" linked above!

James Shubin (1):
  contrib: Add --recursive flag for bash completion

 contrib/completion/git-completion.bash | 1 +
 1 file changed, 1 insertion(+)

base-commit: d9f6f3b6195a0ca35642561e530798ad1469bd41
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-461%2Fpurpleidea%2Ffeat%2Fcompletion-recursive2-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-461/purpleidea/feat/completion-recursive2-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/461

-- 
gitgitgadget

James Shubin via GitGitGadget· Nov 13, 2019, 00:47 UTC · re: James via GitGitGadget · lore

From: James Shubin <james@shubin.ca>

This flag was missing from the list, and I use it quite often :)

Signed-off-by: James Shubin <james@shubin.ca>
---
 contrib/completion/git-completion.bash | 1 +
 1 file changed, 1 insertion(+)

Show changes to contrib/completion/git-completion.bash +1 −0

diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 00fbe6c03d..79fe29ef03 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -2843,6 +2843,7 @@ _git_svn ()
 			--log-window-size= --no-checkout --quiet
 			--repack-flags --use-log-author --localtime
 			--add-author-from
+			--recursive
 			--ignore-paths= --include-paths= $remote_opts
 			"
 		local init_opts="

-- 
gitgitgadget

Junio C Hamano· Nov 13, 2019, 03:45 UTC · re: James Shubin via GitGitGadget · lore

Re: [PATCH 1/1] contrib: Add --recursive flag for bash completion

"James Shubin via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: James Shubin <james@shubin.ca>
> Subject: Re: [PATCH 1/1] contrib: Add --recursive flag for bash completion

The title must make it clear which git subcommand learned the "--recursive" (unless the patch adds it to everything, that is).

    Subject: [PATCH] completion: tab-complete "git svn --recursive"

By the way, it is pointless to send a cover letter for a single patch topic like this; you may want to tell GGG not to do so.

> This flag was missing from the list, and I use it quite often :)

Makes sense.

Thanks.  Will queue with title updated locally.

Show 18 quoted lines

>
> Signed-off-by: James Shubin <james@shubin.ca>
> ---
>  contrib/completion/git-completion.bash | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 00fbe6c03d..79fe29ef03 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -2843,6 +2843,7 @@ _git_svn ()
>  			--log-window-size= --no-checkout --quiet
>  			--repack-flags --use-log-author --localtime
>  			--add-author-from
> +			--recursive
>  			--ignore-paths= --include-paths= $remote_opts
>  			"
>  		local init_opts="

Johannes Schindelin· Nov 13, 2019, 10:17 UTC · re: Junio C Hamano · lore

Re: [PATCH 1/1] contrib: Add --recursive flag for bash completion

Hi Junio,

On Wed, 13 Nov 2019, Junio C Hamano wrote:

Show 12 quoted lines

> "James Shubin via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > From: James Shubin <james@shubin.ca>
> > Subject: Re: [PATCH 1/1] contrib: Add --recursive flag for bash completion
>
> The title must make it clear which git subcommand learned the
> "--recursive" (unless the patch adds it to everything, that is).
>
>     Subject: [PATCH] completion: tab-complete "git svn --recursive"
>
> By the way, it is pointless to send a cover letter for a single
> patch topic like this; you may want to tell GGG not to do so.

In this instance, I totally agree. But in this instance, it would also have made sense to at least scrub the PR description template before sending. Also, it would have made sense to listen to Emily who suggested to have another go at the commit message before sending.

Thanks, Johannes