Re: [PATCH 1/1] contrib: Add --recursive flag for bash completion

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 13, 2019, 03:45 UTC
Message-ID: <xmqqlfskbfru.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <ac8cb233ecea69d46ba5a0af0e63bc7c03963cbf.1573606072.git.gitgitgadget@gmail.com>

"James Shubin via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: James Shubin <james@shubin.ca>
> Subject: Re: [PATCH 1/1] contrib: Add --recursive flag for bash completion

The title must make it clear which git subcommand learned the "--recursive" (unless the patch adds it to everything, that is).

    Subject: [PATCH] completion: tab-complete "git svn --recursive"

By the way, it is pointless to send a cover letter for a single patch topic like this; you may want to tell GGG not to do so.

> This flag was missing from the list, and I use it quite often :)

Makes sense.

Thanks.  Will queue with title updated locally.

Show 18 quoted lines

>
> Signed-off-by: James Shubin <james@shubin.ca>
> ---
>  contrib/completion/git-completion.bash | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 00fbe6c03d..79fe29ef03 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -2843,6 +2843,7 @@ _git_svn ()
>  			--log-window-size= --no-checkout --quiet
>  			--repack-flags --use-log-author --localtime
>  			--add-author-from
> +			--recursive
>  			--ignore-paths= --include-paths= $remote_opts
>  			"
>  		local init_opts="