Re: [PATCH 1/1] contrib: Add --recursive flag for bash completion

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 13, 2019, 10:17 UTC
Message-ID: <nycvar.QRO.7.76.6.1911131116170.46@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqlfskbfru.fsf@gitster-ct.c.googlers.com>

Hi Junio,

On Wed, 13 Nov 2019, Junio C Hamano wrote:

Show 12 quoted lines

> "James Shubin via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > From: James Shubin <james@shubin.ca>
> > Subject: Re: [PATCH 1/1] contrib: Add --recursive flag for bash completion
>
> The title must make it clear which git subcommand learned the
> "--recursive" (unless the patch adds it to everything, that is).
>
>     Subject: [PATCH] completion: tab-complete "git svn --recursive"
>
> By the way, it is pointless to send a cover letter for a single
> patch topic like this; you may want to tell GGG not to do so.

In this instance, I totally agree. But in this instance, it would also have made sense to at least scrub the PR description template before sending. Also, it would have made sense to listen to Emily who suggested to have another go at the commit message before sending.

Thanks, Johannes