{"thread":{"id":"52257","subject":"[PATCH 1/1] contrib: Add --recursive flag for bash completion","startedAt":"2019-11-13T00:48:08Z","lastAt":"2019-11-13T10:18:03Z","messageCount":4,"participants":["James Shubin via GitGitGadget","James via GitGitGadget","Junio C Hamano","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":1},"messages":[{"id":"386071","messageId":"ac8cb233ecea69d46ba5a0af0e63bc7c03963cbf.1573606072.git.gitgitgadget@gmail.com","threadId":"52257","inReplyTo":"pull.461.git.1573606072.gitgitgadget@gmail.com","subject":"[PATCH 1/1] contrib: Add --recursive flag for bash completion","fromName":"James Shubin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2019-11-13T00:47:52Z","receivedAt":"2019-11-13T00:48:08Z","isPatch":true,"sender":{"key":"purpleidea@gmail.com","avatar":"https://gravatar.com/avatar/161941d0314aee3803e1012aa5dedb2403ed9dcd00ec769bce81435493abe18d?d=mp&s=160"},"body":"From: James Shubin \n\nThis flag was missing from the list, and I use it quite often :)\n\nSigned-off-by: James Shubin \n---\n contrib/completion/git-completion.bash | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 00fbe6c03d..79fe29ef03 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -2843,6 +2843,7 @@ _git_svn ()\n \t\t\t--log-window-size= --no-checkout --quiet\n \t\t\t--repack-flags --use-log-author --localtime\n \t\t\t--add-author-from\n+\t\t\t--recursive\n \t\t\t--ignore-paths= --include-paths= $remote_opts\n \t\t\t\"\n \t\tlocal init_opts=\"\n-- \ngitgitgadget\n"},{"id":"386072","messageId":"pull.461.git.1573606072.gitgitgadget@gmail.com","threadId":"52257","inReplyTo":null,"subject":"[PATCH 0/1] contrib: Add --recursive flag for bash completion","fromName":"James via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2019-11-13T00:47:51Z","receivedAt":"2019-11-13T00:48:10Z","isPatch":true,"sender":{"key":"purpleidea@gmail.com","avatar":"https://gravatar.com/avatar/161941d0314aee3803e1012aa5dedb2403ed9dcd00ec769bce81435493abe18d?d=mp&s=160"},"body":"This flag was missing from the list, and I use it quite often :)\n\nSigned-off-by: James Shubin james@shubin.ca [james@shubin.ca]\n\nThanks for taking the time to contribute to Git! Please be advised that the\nGit community does not use github.com for their contributions. Instead, we\nuse a mailing list (git@vger.kernel.org) for code submissions, code reviews,\nand bug reports. Nevertheless, you can use GitGitGadget (\nhttps://gitgitgadget.github.io/) to conveniently send your Pull Requests\ncommits to our mailing list.\n\nPlease read the \"guidelines for contributing\" linked above!\n\nJames Shubin (1):\n contrib: Add --recursive flag for bash completion\n\n contrib/completion/git-completion.bash | 1 +\n 1 file changed, 1 insertion(+)\n\n\nbase-commit: d9f6f3b6195a0ca35642561e530798ad1469bd41\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-461%2Fpurpleidea%2Ffeat%2Fcompletion-recursive2-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-461/purpleidea/feat/completion-recursive2-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/461\n-- \ngitgitgadget\n"},{"id":"386090","messageId":"xmqqlfskbfru.fsf@gitster-ct.c.googlers.com","threadId":"52257","inReplyTo":"ac8cb233ecea69d46ba5a0af0e63bc7c03963cbf.1573606072.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 1/1] contrib: Add --recursive flag for bash completion","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2019-11-13T03:45:41Z","receivedAt":"2019-11-13T03:45:46Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"James Shubin via GitGitGadget\" writes:\n\n> From: James Shubin \n> Subject: Re: [PATCH 1/1] contrib: Add --recursive flag for bash completion\n\nThe title must make it clear which git subcommand learned the\n\"--recursive\" (unless the patch adds it to everything, that is).\n\n Subject: [PATCH] completion: tab-complete \"git svn --recursive\"\n\nBy the way, it is pointless to send a cover letter for a single\npatch topic like this; you may want to tell GGG not to do so.\n\n> This flag was missing from the list, and I use it quite often :)\n\nMakes sense.\n\nThanks. Will queue with title updated locally.\n\n>\n> Signed-off-by: James Shubin \n> ---\n> contrib/completion/git-completion.bash | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\n> index 00fbe6c03d..79fe29ef03 100644\n> --- a/contrib/completion/git-completion.bash\n> +++ b/contrib/completion/git-completion.bash\n> @@ -2843,6 +2843,7 @@ _git_svn ()\n> \t\t\t--log-window-size= --no-checkout --quiet\n> \t\t\t--repack-flags --use-log-author --localtime\n> \t\t\t--add-author-from\n> +\t\t\t--recursive\n> \t\t\t--ignore-paths= --include-paths= $remote_opts\n> \t\t\t\"\n> \t\tlocal init_opts=\"\n"},{"id":"386104","messageId":"nycvar.QRO.7.76.6.1911131116170.46@tvgsbejvaqbjf.bet","threadId":"52257","inReplyTo":"xmqqlfskbfru.fsf@gitster-ct.c.googlers.com","subject":"Re: [PATCH 1/1] contrib: Add --recursive flag for bash completion","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2019-11-13T10:17:36Z","receivedAt":"2019-11-13T10:18:03Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Junio,\n\nOn Wed, 13 Nov 2019, Junio C Hamano wrote:\n\n> \"James Shubin via GitGitGadget\" writes:\n>\n> > From: James Shubin \n> > Subject: Re: [PATCH 1/1] contrib: Add --recursive flag for bash completion\n>\n> The title must make it clear which git subcommand learned the\n> \"--recursive\" (unless the patch adds it to everything, that is).\n>\n> Subject: [PATCH] completion: tab-complete \"git svn --recursive\"\n>\n> By the way, it is pointless to send a cover letter for a single\n> patch topic like this; you may want to tell GGG not to do so.\n\nIn this instance, I totally agree. But in this instance, it would also\nhave made sense to at least scrub the PR description template before\nsending. Also, it would have made sense to listen to Emily who suggested\nto have another go at the commit message before sending.\n\nThanks,\nJohannes\n"}]}