threads / patch / 52035

patchgitk: Preserve window dimensions on exit when not using ttk themes

Subject: [PATCH 0/1] gitk: Preserve window dimensions on exit when not using ttk themes

## tl;dr

3 messages between Oct 15, 2019 and Dec 15, 2019. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Eric Huber via GitGitGadget· Oct 15, 2019, 00:13 UTC · lore

This fix is intended to let gitk preserve the window pane dimensions regardless of whether ttk is enabled or not. I'm not an expert on Tcl/Tk but as far as I can tell, this edit works and doesn't cause problems. Please double-check what I did.

Eric Huber (1):
  gitk: Preserve window dimensions on exit when not using ttk themes

 gitk-git/gitk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

base-commit: 70bf0b755af4d1e66da25b7805cac0e481a082e4
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-389%2Fechuber2%2Fpatch-1-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-389/echuber2/patch-1-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/389

-- 
gitgitgadget

Eric Huber via GitGitGadget· Oct 15, 2019, 00:13 UTC · re: Eric Huber via GitGitGadget · lore

[PATCH 1/1] gitk: Preserve window dimensions on exit when not using ttk themes

From: Eric Huber <echuber2@illinois.edu>

Bug was: gitk would overwrite the botwidth setting in .gitk with a nonsense value when not using tk themes. I'm not sure if this is the right fix or not but it seems to work. Moving the affected line within the conditional results in the expected behavior.

Signed-off-by: Eric Huber <echuber2@illinois.edu>
---
 gitk-git/gitk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Show changes to gitk-git/gitk +2 −2

diff --git a/gitk-git/gitk b/gitk-git/gitk
index abe4805ade..4846f2a983 100755
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -2526,9 +2526,9 @@ proc makewindow {} {
             bind %W <Map> {}
             %W sashpos 0 $::geometry(botwidth)
         }
+	bind .pwbottom <Configure> {resizecdetpanes %W %w}
     }
-
-    bind .pwbottom <Configure> {resizecdetpanes %W %w}
+    
     pack .ctop -fill both -expand 1
     bindall <1> {selcanvline %W %x %y}
     #bindall <B1-Motion> {selcanvline %W %x %y}

-- 
gitgitgadget

Paul Mackerras· Dec 15, 2019, 05:33 UTC · re: Eric Huber via GitGitGadget · lore

Re: [PATCH 1/1] gitk: Preserve window dimensions on exit when not using ttk themes

On Tue, Oct 15, 2019 at 12:13:16AM +0000, Eric Huber via GitGitGadget wrote:

Show 8 quoted lines

> From: Eric Huber <echuber2@illinois.edu>
> 
> Bug was: gitk would overwrite the botwidth setting in .gitk with
> a nonsense value when not using tk themes. I'm not sure if this
> is the right fix or not but it seems to work. Moving the affected
> line within the conditional results in the expected behavior.
> 
> Signed-off-by: Eric Huber <echuber2@illinois.edu>

Thanks, patch applied.

Paul.