{"thread":{"id":"52035","subject":"[PATCH 0/1] gitk: Preserve window dimensions on exit when not using ttk themes","startedAt":"2019-10-15T00:15:06Z","lastAt":"2019-12-15T05:33:39Z","messageCount":3,"participants":["Eric Huber via GitGitGadget","Paul Mackerras"],"isPatch":true,"patchVersion":1,"patchTotal":1},"messages":[{"id":"384049","messageId":"pull.389.git.1571098396.gitgitgadget@gmail.com","threadId":"52035","inReplyTo":null,"subject":"[PATCH 0/1] gitk: Preserve window dimensions on exit when not using ttk themes","fromName":"Eric Huber via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2019-10-15T00:13:15Z","receivedAt":"2019-10-15T00:15:06Z","isPatch":true,"sender":{"key":"name:Eric Huber","avatar":null},"body":"This fix is intended to let gitk preserve the window pane dimensions\nregardless of whether ttk is enabled or not. I'm not an expert on Tcl/Tk but\nas far as I can tell, this edit works and doesn't cause problems. Please\ndouble-check what I did.\n\nEric Huber (1):\n  gitk: Preserve window dimensions on exit when not using ttk themes\n\n gitk-git/gitk | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\n\nbase-commit: 70bf0b755af4d1e66da25b7805cac0e481a082e4\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-389%2Fechuber2%2Fpatch-1-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-389/echuber2/patch-1-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/389\n-- \ngitgitgadget\n"},{"id":"384050","messageId":"364976a833e33696e983bbdd9c1e7974480c1397.1571098396.git.gitgitgadget@gmail.com","threadId":"52035","inReplyTo":"pull.389.git.1571098396.gitgitgadget@gmail.com","subject":"[PATCH 1/1] gitk: Preserve window dimensions on exit when not using ttk themes","fromName":"Eric Huber via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2019-10-15T00:13:16Z","receivedAt":"2019-10-15T00:15:06Z","isPatch":true,"sender":{"key":"name:Eric Huber","avatar":null},"body":"From: Eric Huber <echuber2@illinois.edu>\n\nBug was: gitk would overwrite the botwidth setting in .gitk with\na nonsense value when not using tk themes. I'm not sure if this\nis the right fix or not but it seems to work. Moving the affected\nline within the conditional results in the expected behavior.\n\nSigned-off-by: Eric Huber <echuber2@illinois.edu>\n---\n gitk-git/gitk | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/gitk-git/gitk b/gitk-git/gitk\nindex abe4805ade..4846f2a983 100755\n--- a/gitk-git/gitk\n+++ b/gitk-git/gitk\n@@ -2526,9 +2526,9 @@ proc makewindow {} {\n             bind %W <Map> {}\n             %W sashpos 0 $::geometry(botwidth)\n         }\n+\tbind .pwbottom <Configure> {resizecdetpanes %W %w}\n     }\n-\n-    bind .pwbottom <Configure> {resizecdetpanes %W %w}\n+    \n     pack .ctop -fill both -expand 1\n     bindall <1> {selcanvline %W %x %y}\n     #bindall <B1-Motion> {selcanvline %W %x %y}\n-- \ngitgitgadget\n"},{"id":"388224","messageId":"20191215053304.GF12512@blackberry","threadId":"52035","inReplyTo":"364976a833e33696e983bbdd9c1e7974480c1397.1571098396.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 1/1] gitk: Preserve window dimensions on exit when not using ttk themes","fromName":"Paul Mackerras","fromEmail":"paulus@ozlabs.org","sentAt":"2019-12-15T05:33:04Z","receivedAt":"2019-12-15T05:33:39Z","isPatch":true,"sender":{"key":"paulus@ozlabs.org","avatar":"https://avatars.githubusercontent.com/u/1606439?v=4"},"body":"On Tue, Oct 15, 2019 at 12:13:16AM +0000, Eric Huber via GitGitGadget wrote:\n> From: Eric Huber <echuber2@illinois.edu>\n> \n> Bug was: gitk would overwrite the botwidth setting in .gitk with\n> a nonsense value when not using tk themes. I'm not sure if this\n> is the right fix or not but it seems to work. Moving the affected\n> line within the conditional results in the expected behavior.\n> \n> Signed-off-by: Eric Huber <echuber2@illinois.edu>\n\nThanks, patch applied.\n\nPaul.\n"}]}