# [PATCH 0/1] gitk: Preserve window dimensions on exit when not using ttk themes

3 messages from 2019-10-15 to 2019-12-15. Participants: Eric Huber via GitGitGadget, Paul Mackerras.
Thread: https://gitlist.dev/t/52035

## Eric Huber via GitGitGadget, 2019-10-15 00:13

Subject: [PATCH 0/1] gitk: Preserve window dimensions on exit when not using ttk themes
Message-ID: <pull.389.git.1571098396.gitgitgadget@gmail.com>
URL: https://gitlist.dev/e/pull.389.git.1571098396.gitgitgadget%40gmail.com

```
This fix is intended to let gitk preserve the window pane dimensions
regardless of whether ttk is enabled or not. I'm not an expert on Tcl/Tk but
as far as I can tell, this edit works and doesn't cause problems. Please
double-check what I did.

Eric Huber (1):
  gitk: Preserve window dimensions on exit when not using ttk themes

 gitk-git/gitk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


base-commit: 70bf0b755af4d1e66da25b7805cac0e481a082e4
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-389%2Fechuber2%2Fpatch-1-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-389/echuber2/patch-1-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/389
-- 
gitgitgadget

```

## Eric Huber via GitGitGadget, 2019-10-15 00:13

Subject: [PATCH 1/1] gitk: Preserve window dimensions on exit when not using ttk themes
Message-ID: <364976a833e33696e983bbdd9c1e7974480c1397.1571098396.git.gitgitgadget@gmail.com>
URL: https://gitlist.dev/e/364976a833e33696e983bbdd9c1e7974480c1397.1571098396.git.gitgitgadget%40gmail.com
In-Reply-To: <pull.389.git.1571098396.gitgitgadget@gmail.com>

```
From: Eric Huber <echuber2@illinois.edu>

Bug was: gitk would overwrite the botwidth setting in .gitk with
a nonsense value when not using tk themes. I'm not sure if this
is the right fix or not but it seems to work. Moving the affected
line within the conditional results in the expected behavior.

Signed-off-by: Eric Huber <echuber2@illinois.edu>
---
 gitk-git/gitk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gitk-git/gitk b/gitk-git/gitk
index abe4805ade..4846f2a983 100755
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -2526,9 +2526,9 @@ proc makewindow {} {
             bind %W <Map> {}
             %W sashpos 0 $::geometry(botwidth)
         }
+	bind .pwbottom <Configure> {resizecdetpanes %W %w}
     }
-
-    bind .pwbottom <Configure> {resizecdetpanes %W %w}
+    
     pack .ctop -fill both -expand 1
     bindall <1> {selcanvline %W %x %y}
     #bindall <B1-Motion> {selcanvline %W %x %y}
-- 
gitgitgadget

```

## Paul Mackerras, 2019-12-15 05:33

Subject: Re: [PATCH 1/1] gitk: Preserve window dimensions on exit when not using ttk themes
Message-ID: <20191215053304.GF12512@blackberry>
URL: https://gitlist.dev/e/20191215053304.GF12512%40blackberry
In-Reply-To: <364976a833e33696e983bbdd9c1e7974480c1397.1571098396.git.gitgitgadget@gmail.com>

```
On Tue, Oct 15, 2019 at 12:13:16AM +0000, Eric Huber via GitGitGadget wrote:
> From: Eric Huber <echuber2@illinois.edu>
> 
> Bug was: gitk would overwrite the botwidth setting in .gitk with
> a nonsense value when not using tk themes. I'm not sure if this
> is the right fix or not but it seems to work. Moving the affected
> line within the conditional results in the expected behavior.
> 
> Signed-off-by: Eric Huber <echuber2@illinois.edu>

Thanks, patch applied.

Paul.

```