git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/1] gitk: Preserve window dimensions on exit when not using ttk themes

From
EGEric Huber via GitGitGadget <gitgitgadget@gmail.com>
Date
Oct 15, 2019, 00:13 UTC
Message-ID
<364976a833e33696e983bbdd9c1e7974480c1397.1571098396.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.389.git.1571098396.gitgitgadget@gmail.com>
From: Eric Huber <echuber2@illinois.edu>

Bug was: gitk would overwrite the botwidth setting in .gitk with a nonsense value when not using tk themes. I'm not sure if this is the right fix or not but it seems to work. Moving the affected line within the conditional results in the expected behavior.

Signed-off-by: Eric Huber <echuber2@illinois.edu>
---
 gitk-git/gitk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gitk-git/gitk b/gitk-git/gitk
index abe4805ade..4846f2a983 100755
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -2526,9 +2526,9 @@ proc makewindow {} {
             bind %W <Map> {}
             %W sashpos 0 $::geometry(botwidth)
         }
+	bind .pwbottom <Configure> {resizecdetpanes %W %w}
     }
-
-    bind .pwbottom <Configure> {resizecdetpanes %W %w}
+    
     pack .ctop -fill both -expand 1
     bindall <1> {selcanvline %W %x %y}
     #bindall <B1-Motion> {selcanvline %W %x %y}
-- 
gitgitgadget
Previous: Eric Huber via GitGitGadgetNext: Paul Mackerras
Message 2 of 3 in “gitk: Preserve window dimensions on exit when not using ttk themes”
  1. 0/1 gitk: Preserve window dimensions on exit when not using ttk themesEric Huber via GitGitGadget, Oct 15, 2019
  2. 1/1 gitk: Preserve window dimensions on exit when not using ttk themesEric Huber via GitGitGadget, Oct 15, 2019
  3. Paul MackerrasDec 15, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.