threads / patch / 51740

patchbanned.h: fix vsprintf warning

Subject: [PATCH 0/1] banned.h: fix vsprintf warning

## tl;dr

8 messages between Aug 26, 2019 and Aug 27, 2019. Diffs are folded; open one to read it.

replies: 7people: 4as markdown or json

Andrey Portnoy via GitGitGadget· Aug 26, 2019, 15:21 UTC · lore

Previously sprintf was the argument to the BANNED macro, where vsprintf is expected.

Andrey Portnoy (1):
  banned.h: fix vsprintf warning
 banned.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
base-commit: 75b2f01a0f642b39b0f29b6218515df9b5eb798e
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-322%2Fandportnoy%2Ffix-vsprintf-warning-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-322/andportnoy/fix-vsprintf-warning-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/322
-- 
gitgitgadget
Andrey Portnoy via GitGitGadget· Aug 26, 2019, 15:21 UTC · re: Andrey Portnoy via GitGitGadget · lore

[PATCH 1/1] banned.h: fix vsprintf warning

From: Andrey Portnoy <aportnoy@ucsd.edu>

Previously sprintf was the argument to the BANNED macro, where vsprintf is expected.

Signed-off-by: Andrey Portnoy <aportnoy@ucsd.edu>
---
 banned.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to banned.h +1 −1
diff --git a/banned.h b/banned.h
index 447af24807..60a18d4403 100644
--- a/banned.h
+++ b/banned.h
@@ -26,7 +26,7 @@
 #define vsprintf(...) BANNED(vsprintf)
 #else
 #define sprintf(buf,fmt,arg) BANNED(sprintf)
-#define vsprintf(buf,fmt,arg) BANNED(sprintf)
+#define vsprintf(buf,fmt,arg) BANNED(vsprintf)
 #endif
 
 #endif /* BANNED_H */

-- 
gitgitgadget
Junio C Hamano· Aug 26, 2019, 16:24 UTC · re: Andrey Portnoy via GitGitGadget · lore

Re: [PATCH 0/1] banned.h: fix vsprintf warning

"Andrey Portnoy via GitGitGadget" <gitgitgadget@gmail.com> writes:
> Previously sprintf was the argument to the BANNED macro, where vsprintf is
> expected.
Good eyes.  Thanks.
Show 12 quoted lines
>
> Andrey Portnoy (1):
>   banned.h: fix vsprintf warning
>
>  banned.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> base-commit: 75b2f01a0f642b39b0f29b6218515df9b5eb798e
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-322%2Fandportnoy%2Ffix-vsprintf-warning-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-322/andportnoy/fix-vsprintf-warning-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/322
Jeff King· Aug 26, 2019, 18:33 UTC · re: Junio C Hamano · lore

Re: [PATCH 0/1] banned.h: fix vsprintf warning

On Mon, Aug 26, 2019 at 09:24:10AM -0700, Junio C Hamano wrote:
Show 6 quoted lines
> "Andrey Portnoy via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
> > Previously sprintf was the argument to the BANNED macro, where vsprintf is
> > expected.
> 
> Good eyes.  Thanks.
There's an identical patch in:
  https://public-inbox.org/git/cab687db8315dd4245e1703402a8c76218ee1115.1566762128.git.me@ttaylorr.com/
and both were inspired by:
  https://news.ycombinator.com/item?id=20793298

whose author has little info there, but I think is separate from either submitter.

I don't know if we want to try to spread credit around via trailers. "Racily-implemented-by:" ? :)

Anyway, the original bug is mine and the patch is obviously correct.
-Peff
Taylor Blau· Aug 26, 2019, 18:40 UTC · re: Jeff King · lore

Re: [PATCH 0/1] banned.h: fix vsprintf warning

On Mon, Aug 26, 2019 at 02:33:17PM -0400, Jeff King wrote:
Show 12 quoted lines
> On Mon, Aug 26, 2019 at 09:24:10AM -0700, Junio C Hamano wrote:
>
> > "Andrey Portnoy via GitGitGadget" <gitgitgadget@gmail.com> writes:
> >
> > > Previously sprintf was the argument to the BANNED macro, where vsprintf is
> > > expected.
> >
> > Good eyes.  Thanks.
>
> There's an identical patch in:
>
>   https://public-inbox.org/git/cab687db8315dd4245e1703402a8c76218ee1115.1566762128.git.me@ttaylorr.com/

Thanks for mentioning. I did send mine in around a day ago now, but it came in on a Sunday, so it makes sense that Andrey's message may have appeared earlier in mailboxes when looking today.

I don't really mind about the credit, nor do I think there's much value in crediting you or me with 'Racily-implemented-by'. My patch has a few more details such as blame information (and how the typo was only made in the explicit version, not the variadic form), so it may be worthwhile to take that instead of this, but I don't mind either way.

> and both were inspired by:
>
>   https://news.ycombinator.com/item?id=20793298

Indeed. It was a little surprising to see 'banned.h' at the top of Hacker News when I checked it this weekend :-).

Show 9 quoted lines
> whose author has little info there, but I think is separate from either
> submitter.
>
> I don't know if we want to try to spread credit around via trailers.
> "Racily-implemented-by:" ? :)
>
> Anyway, the original bug is mine and the patch is obviously correct.
>
> -Peff
Yep.

Thanks, Taylor

Junio C Hamano· Aug 27, 2019, 19:46 UTC · re: Taylor Blau · lore

Re: [PATCH 0/1] banned.h: fix vsprintf warning

Taylor Blau <me@ttaylorr.com> writes:
> ... My patch has a few
> more details such as blame information (and how the typo was only made
> in the explicit version, not the variadic form), so it may be worthwhile
> to take that instead of this, but I don't mind either way.

Yup, that was exactly why I took that version (after tentatively queuing the other one, but discarded before pushing the integration result out).

Thanks, all.
>> I don't know if we want to try to spread credit around via trailers.
>> "Racily-implemented-by:" ? :)
Please don't X-<.
Andrey Portnoy· Aug 26, 2019, 19:06 UTC · re: Jeff King · lore

Re: [PATCH 0/1] banned.h: fix vsprintf warning

Show 18 quoted lines
> On Aug 26, 2019, at 11:33 AM, Jeff King <peff@peff.net> wrote:
> 
> On Mon, Aug 26, 2019 at 09:24:10AM -0700, Junio C Hamano wrote:
> 
>> "Andrey Portnoy via GitGitGadget" <gitgitgadget@gmail.com> writes:
>> 
>>> Previously sprintf was the argument to the BANNED macro, where vsprintf is
>>> expected.
>> 
>> Good eyes.  Thanks.
> 
> There's an identical patch in:
> 
>  https://public-inbox.org/git/cab687db8315dd4245e1703402a8c76218ee1115.1566762128.git.me@ttaylorr.com/
> 
> and both were inspired by:
> 
>  https://news.ycombinator.com/item?id=20793298
Nope, mine was not “inspired by” that comment, noticed the bug myself. I did look at this header because it was posted on HN, though.
Show 11 quoted lines
> 
> whose author has little info there, but I think is separate from either
> submitter.
> 
> I don't know if we want to try to spread credit around via trailers.
> "Racily-implemented-by:" ? :)
> 
> Anyway, the original bug is mine and the patch is obviously correct.
> 
> -Peff
>
Andrey Portnoy· Aug 26, 2019, 20:08 UTC · re: Jeff King · lore

Re: [PATCH 0/1] banned.h: fix vsprintf warning

Show 18 quoted lines
> On Aug 26, 2019, at 11:33 AM, Jeff King <peff@peff.net> wrote:
> 
> On Mon, Aug 26, 2019 at 09:24:10AM -0700, Junio C Hamano wrote:
> 
>> "Andrey Portnoy via GitGitGadget" <gitgitgadget@gmail.com> writes:
>> 
>>> Previously sprintf was the argument to the BANNED macro, where vsprintf is
>>> expected.
>> 
>> Good eyes.  Thanks.
> 
> There's an identical patch in:
> 
> https://public-inbox.org/git/cab687db8315dd4245e1703402a8c76218ee1115.1566762128.git.me@ttaylorr.com/
> 
> and both were inspired by:
> 
> https://news.ycombinator.com/item?id=20793298
Nope, mine was not “inspired by” that comment, noticed the bug myself. I did look at this header because it was posted on HN, though.
Show 11 quoted lines
> 
> whose author has little info there, but I think is separate from either
> submitter.
> 
> I don't know if we want to try to spread credit around via trailers.
> "Racily-implemented-by:" ? :)
> 
> Anyway, the original bug is mine and the patch is obviously correct.
> 
> -Peff
>

← back to recent threads