{"thread":{"id":"51740","subject":"[PATCH 0/1] banned.h: fix vsprintf warning","startedAt":"2019-08-26T15:21:54Z","lastAt":"2019-08-27T19:46:32Z","messageCount":8,"participants":["Andrey Portnoy via GitGitGadget","Junio C Hamano","Jeff King","Taylor Blau","Andrey Portnoy"],"isPatch":true,"patchVersion":1,"patchTotal":1},"messages":[{"id":"381191","messageId":"pull.322.git.gitgitgadget@gmail.com","threadId":"51740","inReplyTo":null,"subject":"[PATCH 0/1] banned.h: fix vsprintf warning","fromName":"Andrey Portnoy via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2019-08-26T15:21:50Z","receivedAt":"2019-08-26T15:21:54Z","isPatch":true,"sender":{"key":"aportnoy@ucsd.edu","avatar":null},"body":"Previously sprintf was the argument to the BANNED macro, where vsprintf is\nexpected.\n\nAndrey Portnoy (1):\n banned.h: fix vsprintf warning\n\n banned.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n\nbase-commit: 75b2f01a0f642b39b0f29b6218515df9b5eb798e\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-322%2Fandportnoy%2Ffix-vsprintf-warning-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-322/andportnoy/fix-vsprintf-warning-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/322\n-- \ngitgitgadget\n"},{"id":"381192","messageId":"148e4c1f06ebf86664cd7fa3007fa9e09962c95d.1566832910.git.gitgitgadget@gmail.com","threadId":"51740","inReplyTo":"pull.322.git.gitgitgadget@gmail.com","subject":"[PATCH 1/1] banned.h: fix vsprintf warning","fromName":"Andrey Portnoy via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2019-08-26T15:21:51Z","receivedAt":"2019-08-26T15:21:55Z","isPatch":true,"sender":{"key":"aportnoy@ucsd.edu","avatar":null},"body":"From: Andrey Portnoy \n\nPreviously sprintf was the argument to the BANNED macro, where vsprintf\nis expected.\n\nSigned-off-by: Andrey Portnoy \n---\n banned.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/banned.h b/banned.h\nindex 447af24807..60a18d4403 100644\n--- a/banned.h\n+++ b/banned.h\n@@ -26,7 +26,7 @@\n #define vsprintf(...) BANNED(vsprintf)\n #else\n #define sprintf(buf,fmt,arg) BANNED(sprintf)\n-#define vsprintf(buf,fmt,arg) BANNED(sprintf)\n+#define vsprintf(buf,fmt,arg) BANNED(vsprintf)\n #endif\n \n #endif /* BANNED_H */\n-- \ngitgitgadget\n"},{"id":"381203","messageId":"xmqqwoezj3o5.fsf@gitster-ct.c.googlers.com","threadId":"51740","inReplyTo":"pull.322.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 0/1] banned.h: fix vsprintf warning","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2019-08-26T16:24:10Z","receivedAt":"2019-08-26T16:24:15Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Andrey Portnoy via GitGitGadget\" writes:\n\n> Previously sprintf was the argument to the BANNED macro, where vsprintf is\n> expected.\n\nGood eyes. Thanks.\n\n\n>\n> Andrey Portnoy (1):\n> banned.h: fix vsprintf warning\n>\n> banned.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n>\n> base-commit: 75b2f01a0f642b39b0f29b6218515df9b5eb798e\n> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-322%2Fandportnoy%2Ffix-vsprintf-warning-v1\n> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-322/andportnoy/fix-vsprintf-warning-v1\n> Pull-Request: https://github.com/gitgitgadget/git/pull/322\n"},{"id":"381229","messageId":"20190826183317.GB23399@sigill.intra.peff.net","threadId":"51740","inReplyTo":"xmqqwoezj3o5.fsf@gitster-ct.c.googlers.com","subject":"Re: [PATCH 0/1] banned.h: fix vsprintf warning","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2019-08-26T18:33:17Z","receivedAt":"2019-08-26T18:33:20Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Mon, Aug 26, 2019 at 09:24:10AM -0700, Junio C Hamano wrote:\n\n> \"Andrey Portnoy via GitGitGadget\" writes:\n> \n> > Previously sprintf was the argument to the BANNED macro, where vsprintf is\n> > expected.\n> \n> Good eyes. Thanks.\n\nThere's an identical patch in:\n\n https://public-inbox.org/git/cab687db8315dd4245e1703402a8c76218ee1115.1566762128.git.me@ttaylorr.com/\n\nand both were inspired by:\n\n https://news.ycombinator.com/item?id=20793298\n\nwhose author has little info there, but I think is separate from either\nsubmitter.\n\nI don't know if we want to try to spread credit around via trailers.\n\"Racily-implemented-by:\" ? :)\n\nAnyway, the original bug is mine and the patch is obviously correct.\n\n-Peff\n"},{"id":"381230","messageId":"20190826184022.GA30349@syl.lan","threadId":"51740","inReplyTo":"20190826183317.GB23399@sigill.intra.peff.net","subject":"Re: [PATCH 0/1] banned.h: fix vsprintf warning","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2019-08-26T18:40:22Z","receivedAt":"2019-08-26T18:40:26Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Mon, Aug 26, 2019 at 02:33:17PM -0400, Jeff King wrote:\n> On Mon, Aug 26, 2019 at 09:24:10AM -0700, Junio C Hamano wrote:\n>\n> > \"Andrey Portnoy via GitGitGadget\" writes:\n> >\n> > > Previously sprintf was the argument to the BANNED macro, where vsprintf is\n> > > expected.\n> >\n> > Good eyes. Thanks.\n>\n> There's an identical patch in:\n>\n> https://public-inbox.org/git/cab687db8315dd4245e1703402a8c76218ee1115.1566762128.git.me@ttaylorr.com/\n\nThanks for mentioning. I did send mine in around a day ago now, but it\ncame in on a Sunday, so it makes sense that Andrey's message may have\nappeared earlier in mailboxes when looking today.\n\nI don't really mind about the credit, nor do I think there's much value\nin crediting you or me with 'Racily-implemented-by'. My patch has a few\nmore details such as blame information (and how the typo was only made\nin the explicit version, not the variadic form), so it may be worthwhile\nto take that instead of this, but I don't mind either way.\n\n> and both were inspired by:\n>\n> https://news.ycombinator.com/item?id=20793298\n\nIndeed. It was a little surprising to see 'banned.h' at the top of\nHacker News when I checked it this weekend :-).\n\n> whose author has little info there, but I think is separate from either\n> submitter.\n>\n> I don't know if we want to try to spread credit around via trailers.\n> \"Racily-implemented-by:\" ? :)\n>\n> Anyway, the original bug is mine and the patch is obviously correct.\n>\n> -Peff\n\nYep.\n\nThanks,\nTaylor\n"},{"id":"381251","messageId":"E17AF17D-AF64-4791-A38A-6510923005FC@ucsd.edu","threadId":"51740","inReplyTo":"20190826183317.GB23399@sigill.intra.peff.net","subject":"Re: [PATCH 0/1] banned.h: fix vsprintf warning","fromName":"Andrey Portnoy","fromEmail":"aportnoy@ucsd.edu","sentAt":"2019-08-26T19:06:11Z","receivedAt":"2019-08-26T20:08:09Z","isPatch":true,"sender":{"key":"aportnoy@ucsd.edu","avatar":null},"body":"\n\n> On Aug 26, 2019, at 11:33 AM, Jeff King wrote:\n> \n> On Mon, Aug 26, 2019 at 09:24:10AM -0700, Junio C Hamano wrote:\n> \n>> \"Andrey Portnoy via GitGitGadget\" writes:\n>> \n>>> Previously sprintf was the argument to the BANNED macro, where vsprintf is\n>>> expected.\n>> \n>> Good eyes. Thanks.\n> \n> There's an identical patch in:\n> \n> https://public-inbox.org/git/cab687db8315dd4245e1703402a8c76218ee1115.1566762128.git.me@ttaylorr.com/\n> \n> and both were inspired by:\n> \n> https://news.ycombinator.com/item?id=20793298\nNope, mine was not “inspired by” that comment, noticed the bug myself. I did look at this header because it was posted on HN, though.\n> \n> whose author has little info there, but I think is separate from either\n> submitter.\n> \n> I don't know if we want to try to spread credit around via trailers.\n> \"Racily-implemented-by:\" ? :)\n> \n> Anyway, the original bug is mine and the patch is obviously correct.\n> \n> -Peff\n> \n\n"},{"id":"381252","messageId":"0766F8E0-9A36-4304-A99D-35CC65063F3A@ucsd.edu","threadId":"51740","inReplyTo":"20190826183317.GB23399@sigill.intra.peff.net","subject":"Re: [PATCH 0/1] banned.h: fix vsprintf warning","fromName":"Andrey Portnoy","fromEmail":"aportnoy@ucsd.edu","sentAt":"2019-08-26T20:08:16Z","receivedAt":"2019-08-26T20:08:27Z","isPatch":true,"sender":{"key":"aportnoy@ucsd.edu","avatar":null},"body":"\n\n> On Aug 26, 2019, at 11:33 AM, Jeff King wrote:\n> \n> On Mon, Aug 26, 2019 at 09:24:10AM -0700, Junio C Hamano wrote:\n> \n>> \"Andrey Portnoy via GitGitGadget\" writes:\n>> \n>>> Previously sprintf was the argument to the BANNED macro, where vsprintf is\n>>> expected.\n>> \n>> Good eyes. Thanks.\n> \n> There's an identical patch in:\n> \n> https://public-inbox.org/git/cab687db8315dd4245e1703402a8c76218ee1115.1566762128.git.me@ttaylorr.com/\n> \n> and both were inspired by:\n> \n> https://news.ycombinator.com/item?id=20793298\nNope, mine was not “inspired by” that comment, noticed the bug myself. I did look at this header because it was posted on HN, though.\n> \n> whose author has little info there, but I think is separate from either\n> submitter.\n> \n> I don't know if we want to try to spread credit around via trailers.\n> \"Racily-implemented-by:\" ? :)\n> \n> Anyway, the original bug is mine and the patch is obviously correct.\n> \n> -Peff\n> \n\n"},{"id":"381389","messageId":"xmqqv9ui2xyk.fsf@gitster-ct.c.googlers.com","threadId":"51740","inReplyTo":"20190826184022.GA30349@syl.lan","subject":"Re: [PATCH 0/1] banned.h: fix vsprintf warning","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2019-08-27T19:46:27Z","receivedAt":"2019-08-27T19:46:32Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Taylor Blau writes:\n\n> ... My patch has a few\n> more details such as blame information (and how the typo was only made\n> in the explicit version, not the variadic form), so it may be worthwhile\n> to take that instead of this, but I don't mind either way.\n\nYup, that was exactly why I took that version (after tentatively\nqueuing the other one, but discarded before pushing the integration\nresult out).\n\nThanks, all.\n\n>> I don't know if we want to try to spread credit around via trailers.\n>> \"Racily-implemented-by:\" ? :)\n\nPlease don't X-<.\n"}]}