Re: [PATCH 0/1] banned.h: fix vsprintf warning

From: Jeff King <peff@peff.net>
Date: Aug 26, 2019, 18:33 UTC
Message-ID: <20190826183317.GB23399@sigill.intra.peff.net>
In-Reply-To: <xmqqwoezj3o5.fsf@gitster-ct.c.googlers.com>

On Mon, Aug 26, 2019 at 09:24:10AM -0700, Junio C Hamano wrote:

Show 6 quoted lines

> "Andrey Portnoy via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
> > Previously sprintf was the argument to the BANNED macro, where vsprintf is
> > expected.
> 
> Good eyes.  Thanks.

There's an identical patch in:

  https://public-inbox.org/git/cab687db8315dd4245e1703402a8c76218ee1115.1566762128.git.me@ttaylorr.com/

and both were inspired by:

  https://news.ycombinator.com/item?id=20793298

whose author has little info there, but I think is separate from either submitter.

I don't know if we want to try to spread credit around via trailers. "Racily-implemented-by:" ? :)

Anyway, the original bug is mine and the patch is obviously correct.

-Peff