Re: [PATCH 0/1] banned.h: fix vsprintf warning

From: Taylor Blau <me@ttaylorr.com>
Date: Aug 26, 2019, 18:40 UTC
Message-ID: <20190826184022.GA30349@syl.lan>
In-Reply-To: <20190826183317.GB23399@sigill.intra.peff.net>

On Mon, Aug 26, 2019 at 02:33:17PM -0400, Jeff King wrote:

Show 12 quoted lines

> On Mon, Aug 26, 2019 at 09:24:10AM -0700, Junio C Hamano wrote:
>
> > "Andrey Portnoy via GitGitGadget" <gitgitgadget@gmail.com> writes:
> >
> > > Previously sprintf was the argument to the BANNED macro, where vsprintf is
> > > expected.
> >
> > Good eyes.  Thanks.
>
> There's an identical patch in:
>
>   https://public-inbox.org/git/cab687db8315dd4245e1703402a8c76218ee1115.1566762128.git.me@ttaylorr.com/

Thanks for mentioning. I did send mine in around a day ago now, but it came in on a Sunday, so it makes sense that Andrey's message may have appeared earlier in mailboxes when looking today.

I don't really mind about the credit, nor do I think there's much value in crediting you or me with 'Racily-implemented-by'. My patch has a few more details such as blame information (and how the typo was only made in the explicit version, not the variadic form), so it may be worthwhile to take that instead of this, but I don't mind either way.

> and both were inspired by:
>
>   https://news.ycombinator.com/item?id=20793298

Indeed. It was a little surprising to see 'banned.h' at the top of Hacker News when I checked it this weekend :-).

Show 9 quoted lines

> whose author has little info there, but I think is separate from either
> submitter.
>
> I don't know if we want to try to spread credit around via trailers.
> "Racily-implemented-by:" ? :)
>
> Anyway, the original bug is mine and the patch is obviously correct.
>
> -Peff

Yep.

Thanks, Taylor