[PATCH] packfile.h: drop extern from function declaration

Denton Liu· Aug 19, 2019, 06:26 UTC · lore

In 336226c259 (packfile.h: drop extern from function declarations, 2019-04-05), `extern` was removed from function declarations because it's redundant. However, in 8434e85d5f (repack: refactor pack deletion for future use, 2019-06-10), an `extern` was mistakenly included.

Remove this spurious `extern`.

Signed-off-by: Denton Liu <liu.denton@gmail.com>
---
 packfile.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to packfile.h +1 −1

diff --git a/packfile.h b/packfile.h
index 3e98910bdd..fc7904ec81 100644
--- a/packfile.h
+++ b/packfile.h
@@ -100,7 +100,7 @@ struct packed_git *add_packed_git(const char *path, size_t path_len, int local);
  * Does not unlink if 'force_delete' is false and the pack-file is
  * marked as ".keep".
  */
-extern void unlink_pack_path(const char *pack_name, int force_delete);
+void unlink_pack_path(const char *pack_name, int force_delete);
 
 /*
  * Make sure that a pointer access into an mmap'd index file is within bounds,

-- 
2.23.0.248.g3a9dd8fb08

Jeff King· Aug 23, 2019, 06:00 UTC · re: Denton Liu · lore

Re: [PATCH] packfile.h: drop extern from function declaration

On Mon, Aug 19, 2019 at 02:26:19AM -0400, Denton Liu wrote:

Show 6 quoted lines

> In 336226c259 (packfile.h: drop extern from function declarations,
> 2019-04-05), `extern` was removed from function declarations because
> it's redundant. However, in 8434e85d5f (repack: refactor pack deletion
> for future use, 2019-06-10), an `extern` was mistakenly included.
> 
> Remove this spurious `extern`.

Thanks. This looks obviously correct.

-Peff

patchpackfile.h: drop extern from function declaration