{"thread":{"id":"51671","subject":"[PATCH] packfile.h: drop extern from function declaration","startedAt":"2019-08-19T06:26:24Z","lastAt":"2019-08-23T06:00:41Z","messageCount":2,"participants":["Denton Liu","Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"380687","messageId":"58862d9d6f4eb1af7ac6a09a703c2ace66917ee3.1566195817.git.liu.denton@gmail.com","threadId":"51671","inReplyTo":null,"subject":"[PATCH] packfile.h: drop extern from function declaration","fromName":"Denton Liu","fromEmail":"liu.denton@gmail.com","sentAt":"2019-08-19T06:26:19Z","receivedAt":"2019-08-19T06:26:24Z","isPatch":true,"sender":{"key":"liu.denton@gmail.com","avatar":"https://avatars.githubusercontent.com/u/9620836?v=4"},"body":"In 336226c259 (packfile.h: drop extern from function declarations,\n2019-04-05), `extern` was removed from function declarations because\nit's redundant. However, in 8434e85d5f (repack: refactor pack deletion\nfor future use, 2019-06-10), an `extern` was mistakenly included.\n\nRemove this spurious `extern`.\n\nSigned-off-by: Denton Liu <liu.denton@gmail.com>\n---\n packfile.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/packfile.h b/packfile.h\nindex 3e98910bdd..fc7904ec81 100644\n--- a/packfile.h\n+++ b/packfile.h\n@@ -100,7 +100,7 @@ struct packed_git *add_packed_git(const char *path, size_t path_len, int local);\n  * Does not unlink if 'force_delete' is false and the pack-file is\n  * marked as \".keep\".\n  */\n-extern void unlink_pack_path(const char *pack_name, int force_delete);\n+void unlink_pack_path(const char *pack_name, int force_delete);\n \n /*\n  * Make sure that a pointer access into an mmap'd index file is within bounds,\n-- \n2.23.0.248.g3a9dd8fb08\n\n"},{"id":"380997","messageId":"20190823060038.GB10806@sigill.intra.peff.net","threadId":"51671","inReplyTo":"58862d9d6f4eb1af7ac6a09a703c2ace66917ee3.1566195817.git.liu.denton@gmail.com","subject":"Re: [PATCH] packfile.h: drop extern from function declaration","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2019-08-23T06:00:39Z","receivedAt":"2019-08-23T06:00:41Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Mon, Aug 19, 2019 at 02:26:19AM -0400, Denton Liu wrote:\n\n> In 336226c259 (packfile.h: drop extern from function declarations,\n> 2019-04-05), `extern` was removed from function declarations because\n> it's redundant. However, in 8434e85d5f (repack: refactor pack deletion\n> for future use, 2019-06-10), an `extern` was mistakenly included.\n> \n> Remove this spurious `extern`.\n\nThanks. This looks obviously correct.\n\n-Peff\n"}]}