git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] packfile.h: drop extern from function declaration

From
Denton Liu <liu.denton@gmail.com>
Date
Aug 19, 2019, 06:26 UTC
Message-ID
<58862d9d6f4eb1af7ac6a09a703c2ace66917ee3.1566195817.git.liu.denton@gmail.com>

In 336226c259 (packfile.h: drop extern from function declarations, 2019-04-05), `extern` was removed from function declarations because it's redundant. However, in 8434e85d5f (repack: refactor pack deletion for future use, 2019-06-10), an `extern` was mistakenly included.

Remove this spurious `extern`.
Signed-off-by: Denton Liu <liu.denton@gmail.com>
---
 packfile.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/packfile.h b/packfile.h
index 3e98910bdd..fc7904ec81 100644
--- a/packfile.h
+++ b/packfile.h
@@ -100,7 +100,7 @@ struct packed_git *add_packed_git(const char *path, size_t path_len, int local);
  * Does not unlink if 'force_delete' is false and the pack-file is
  * marked as ".keep".
  */
-extern void unlink_pack_path(const char *pack_name, int force_delete);
+void unlink_pack_path(const char *pack_name, int force_delete);
 
 /*
  * Make sure that a pointer access into an mmap'd index file is within bounds,
-- 
2.23.0.248.g3a9dd8fb08
Next: Jeff King
Message 1 of 2 in “packfile.h: drop extern from function declaration”
  1. packfile.h: drop extern from function declarationDenton Liu, Aug 19, 2019
  2. Jeff KingAug 23, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.