# [PATCH] packfile.h: drop extern from function declaration 2 messages from 2019-08-19 to 2019-08-23. Participants: Denton Liu, Jeff King. Thread: https://gitlist.dev/t/51671 ## Denton Liu, 2019-08-19 06:26 Subject: [PATCH] packfile.h: drop extern from function declaration Message-ID: <58862d9d6f4eb1af7ac6a09a703c2ace66917ee3.1566195817.git.liu.denton@gmail.com> URL: https://gitlist.dev/e/58862d9d6f4eb1af7ac6a09a703c2ace66917ee3.1566195817.git.liu.denton%40gmail.com ``` In 336226c259 (packfile.h: drop extern from function declarations, 2019-04-05), `extern` was removed from function declarations because it's redundant. However, in 8434e85d5f (repack: refactor pack deletion for future use, 2019-06-10), an `extern` was mistakenly included. Remove this spurious `extern`. Signed-off-by: Denton Liu --- packfile.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packfile.h b/packfile.h index 3e98910bdd..fc7904ec81 100644 --- a/packfile.h +++ b/packfile.h @@ -100,7 +100,7 @@ struct packed_git *add_packed_git(const char *path, size_t path_len, int local); * Does not unlink if 'force_delete' is false and the pack-file is * marked as ".keep". */ -extern void unlink_pack_path(const char *pack_name, int force_delete); +void unlink_pack_path(const char *pack_name, int force_delete); /* * Make sure that a pointer access into an mmap'd index file is within bounds, -- 2.23.0.248.g3a9dd8fb08 ``` ## Jeff King, 2019-08-23 06:00 Subject: Re: [PATCH] packfile.h: drop extern from function declaration Message-ID: <20190823060038.GB10806@sigill.intra.peff.net> URL: https://gitlist.dev/e/20190823060038.GB10806%40sigill.intra.peff.net In-Reply-To: <58862d9d6f4eb1af7ac6a09a703c2ace66917ee3.1566195817.git.liu.denton@gmail.com> ``` On Mon, Aug 19, 2019 at 02:26:19AM -0400, Denton Liu wrote: > In 336226c259 (packfile.h: drop extern from function declarations, > 2019-04-05), `extern` was removed from function declarations because > it's redundant. However, in 8434e85d5f (repack: refactor pack deletion > for future use, 2019-06-10), an `extern` was mistakenly included. > > Remove this spurious `extern`. Thanks. This looks obviously correct. -Peff ```