threads / patch / 50140

patchdoc: remove unneeded TODO for release_commit_memory

Subject: [PATCH] doc: remove unneeded TODO for release_commit_memory

## tl;dr

5 messages between Dec 31, 2018 and Jan 3, 2019. Diffs are folded; open one to read it.

replies: 4people: 3as markdown or json

Albert Burt· Dec 31, 2018, 23:57 UTC · lore

The code that was merged with commit 1102405 left in an TODO that is no longer relevant. It seems as if we can remove this todo. util seems to not be a field of the struct commit, definition of struct commit --> commit.c:27 The commit list also, does not contain a field for util.

____ By making a contribution to this project, I certify that:

a. The contribution was created in whole or in part by me and I
   have the right to submit it under the open source license
   indicated in the file; or
b. The contribution is based upon previous work that, to the best
   of my knowledge, is covered under an appropriate open source
   license and I have the right under that license to submit that
   work with modifications, whether created in whole or in part
   by me, under the same open source license (unless I am
   permitted to submit under a different license), as indicated
   in the file; or
c. The contribution was provided directly to me by some other
   person who certified (a), (b) or (c) and I have not modified
   it.
d. I understand and agree that this project and the contribution
   are public and that a record of the contribution (including all
   personal information I submit with it, including my sign-off) is
   maintained indefinitely and may be redistributed consistent with
   this project or the open source license(s) involved.
____
Signed-off-by: Albert Burt <aburthinds@gmail.com>
---
 commit.c | 2 --
 1 file changed, 2 deletions(-)
Show changes to commit.c +0 −2
diff --git a/commit.c b/commit.c
index 2d94e0b199..2ff6dca0bc 100644
--- a/commit.c
+++ b/commit.c
@@ -357,8 +357,6 @@ void release_commit_memory(struct commit *c)
 	c->index = 0;
 	free_commit_buffer(c);
 	free_commit_list(c->parents);
-	/* TODO: what about commit->util? */
-
 	c->object.parsed = 0;
 }
 

-- 
2.17.2 (Apple Git-113)
Duy Nguyen· Jan 1, 2019, 10:40 UTC · re: Albert Burt · lore

Re: [PATCH] doc: remove unneeded TODO for release_commit_memory

On Tue, Jan 1, 2019 at 7:02 AM Albert Burt <aburthinds@gmail.com> wrote:
>
> The code that was merged with commit 1102405 left in an TODO that
People usually use something this to produce the commit reference
    git show -s --date=short --pretty='format:%h (%s - %ad)'
which produces
110240588d (Merge branch 'sb/object-store-alloc' - 2018-06-25)
> is no longer relevant. It seems as if we can remove this todo.
> util seems to not be a field of the struct commit,
> definition of struct commit --> commit.c:27
> The commit list also, does not contain a field for util.

There was commit->util, which was deleted in 9d2c97016f (commit.h: delete 'util' field in struct commit - 2018-05-19). You can mention it too if you reroll this patch.

Show 25 quoted lines
> ____
> By making a contribution to this project, I certify that:
>
> a. The contribution was created in whole or in part by me and I
>    have the right to submit it under the open source license
>    indicated in the file; or
>
> b. The contribution is based upon previous work that, to the best
>    of my knowledge, is covered under an appropriate open source
>    license and I have the right under that license to submit that
>    work with modifications, whether created in whole or in part
>    by me, under the same open source license (unless I am
>    permitted to submit under a different license), as indicated
>    in the file; or
>
> c. The contribution was provided directly to me by some other
>    person who certified (a), (b) or (c) and I have not modified
>    it.
>
> d. I understand and agree that this project and the contribution
>    are public and that a record of the contribution (including all
>    personal information I submit with it, including my sign-off) is
>    maintained indefinitely and may be redistributed consistent with
>    this project or the open source license(s) involved.
> ____
I think you can drop this. Your S-o-b below implies all this.
Show 15 quoted lines
> Signed-off-by: Albert Burt <aburthinds@gmail.com>
> ---
>  commit.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/commit.c b/commit.c
> index 2d94e0b199..2ff6dca0bc 100644
> --- a/commit.c
> +++ b/commit.c
> @@ -357,8 +357,6 @@ void release_commit_memory(struct commit *c)
>         c->index = 0;
>         free_commit_buffer(c);
>         free_commit_list(c->parents);
> -       /* TODO: what about commit->util? */
> -
Obviously correct :)
Show 6 quoted lines
>         c->object.parsed = 0;
>  }
>
> --
> 2.17.2 (Apple Git-113)
>
-- 
Duy
Albert Burt· Jan 1, 2019, 20:08 UTC · re: Duy Nguyen · lore

[PATCH v2] doc: remove unneeded TODO for release_commit_memory

Remove TODO that was left in from: commit 110240588d (Merge branch 'sb/object-store-alloc' - 2018-06-25)

Todo can be removed as: 9d2c97016f (commit.h: delete 'util' field in struct commit - 2018-05-19) deletes commit->util.

Signed-off-by: Albert Burt <aburthinds@gmail.com>
---

Thanks for looking at this for me Duy. I updated some of the changes you suggested.

Let me know if there's anything else that I would need to clean up, or do better. :)

 commit.c | 2 --
 1 file changed, 2 deletions(-)
Show changes to commit.c +0 −2
diff --git a/commit.c b/commit.c
index 2d94e0b199..2ff6dca0bc 100644
--- a/commit.c
+++ b/commit.c
@@ -357,8 +357,6 @@ void release_commit_memory(struct commit *c)
 	c->index = 0;
 	free_commit_buffer(c);
 	free_commit_list(c->parents);
-	/* TODO: what about commit->util? */
-
 	c->object.parsed = 0;
 }
 

-- 
2.17.2 (Apple Git-113)
Duy Nguyen· Jan 2, 2019, 11:17 UTC · re: Albert Burt · lore

Re: [PATCH v2] doc: remove unneeded TODO for release_commit_memory

On Wed, Jan 2, 2019 at 3:09 AM Albert Burt <aburthinds@gmail.com> wrote:
Show 16 quoted lines
>
> Remove TODO that was left in from:
> commit 110240588d (Merge branch 'sb/object-store-alloc' - 2018-06-25)
>
> Todo can be removed as:
> 9d2c97016f (commit.h: delete 'util' field in struct commit - 2018-05-19)
> deletes commit->util.
>
> Signed-off-by: Albert Burt <aburthinds@gmail.com>
> ---
>
> Thanks for looking at this for me Duy. I updated some of the changes you
> suggested.
>
> Let me know if there's anything else that I would need to clean up, or do better.
> :)
Nope. The patch looks good to me.
Show 20 quoted lines
>
>  commit.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/commit.c b/commit.c
> index 2d94e0b199..2ff6dca0bc 100644
> --- a/commit.c
> +++ b/commit.c
> @@ -357,8 +357,6 @@ void release_commit_memory(struct commit *c)
>         c->index = 0;
>         free_commit_buffer(c);
>         free_commit_list(c->parents);
> -       /* TODO: what about commit->util? */
> -
>         c->object.parsed = 0;
>  }
>
> --
> 2.17.2 (Apple Git-113)
>
-- 
Duy
Junio C Hamano· Jan 3, 2019, 07:21 UTC · re: Duy Nguyen · lore

Re: [PATCH v2] doc: remove unneeded TODO for release_commit_memory

Duy Nguyen <pclouds@gmail.com> writes:
Show 19 quoted lines
> On Wed, Jan 2, 2019 at 3:09 AM Albert Burt <aburthinds@gmail.com> wrote:
>>
>> Remove TODO that was left in from:
>> commit 110240588d (Merge branch 'sb/object-store-alloc' - 2018-06-25)
>>
>> Todo can be removed as:
>> 9d2c97016f (commit.h: delete 'util' field in struct commit - 2018-05-19)
>> deletes commit->util.
>>
>> Signed-off-by: Albert Burt <aburthinds@gmail.com>
>> ---
>>
>> Thanks for looking at this for me Duy. I updated some of the changes you
>> suggested.
>>
>> Let me know if there's anything else that I would need to clean up, or do better.
>> :)
>
> Nope. The patch looks good to me.

Yes, but we'll fix this with 6a7895fd ("commit: prepare free_commit_buffer and release_commit_memory for any repo", 2018-12-14) anyway, so I am not sure if this is worth pursuing separately.

Show 21 quoted lines
>
>>
>>  commit.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/commit.c b/commit.c
>> index 2d94e0b199..2ff6dca0bc 100644
>> --- a/commit.c
>> +++ b/commit.c
>> @@ -357,8 +357,6 @@ void release_commit_memory(struct commit *c)
>>         c->index = 0;
>>         free_commit_buffer(c);
>>         free_commit_list(c->parents);
>> -       /* TODO: what about commit->util? */
>> -
>>         c->object.parsed = 0;
>>  }
>>
>> --
>> 2.17.2 (Apple Git-113)
>>

← back to recent threads