{"thread":{"id":"50140","subject":"[PATCH] doc: remove unneeded TODO for release_commit_memory","startedAt":"2018-12-31T23:57:45Z","lastAt":"2019-01-03T07:22:01Z","messageCount":5,"participants":["Albert Burt","Duy Nguyen","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"366015","messageId":"20181231235713.76200-1-aburthinds@gmail.com","threadId":"50140","inReplyTo":null,"subject":"[PATCH] doc: remove unneeded TODO for release_commit_memory","fromName":"Albert Burt","fromEmail":"aburthinds@gmail.com","sentAt":"2018-12-31T23:57:13Z","receivedAt":"2018-12-31T23:57:45Z","isPatch":true,"sender":{"key":"aburthinds@gmail.com","avatar":null},"body":"The code that was merged with commit 1102405 left in an TODO that\nis no longer relevant. It seems as if we can remove this todo.\nutil seems to not be a field of the struct commit,\ndefinition of struct commit --> commit.c:27\nThe commit list also, does not contain a field for util.\n\n____\nBy making a contribution to this project, I certify that:\n\na. The contribution was created in whole or in part by me and I\n have the right to submit it under the open source license\n indicated in the file; or\n\nb. The contribution is based upon previous work that, to the best\n of my knowledge, is covered under an appropriate open source\n license and I have the right under that license to submit that\n work with modifications, whether created in whole or in part\n by me, under the same open source license (unless I am\n permitted to submit under a different license), as indicated\n in the file; or\n\nc. The contribution was provided directly to me by some other\n person who certified (a), (b) or (c) and I have not modified\n it.\n\nd. I understand and agree that this project and the contribution\n are public and that a record of the contribution (including all\n personal information I submit with it, including my sign-off) is\n maintained indefinitely and may be redistributed consistent with\n this project or the open source license(s) involved.\n____\n\nSigned-off-by: Albert Burt \n---\n commit.c | 2 --\n 1 file changed, 2 deletions(-)\n\ndiff --git a/commit.c b/commit.c\nindex 2d94e0b199..2ff6dca0bc 100644\n--- a/commit.c\n+++ b/commit.c\n@@ -357,8 +357,6 @@ void release_commit_memory(struct commit *c)\n \tc->index = 0;\n \tfree_commit_buffer(c);\n \tfree_commit_list(c->parents);\n-\t/* TODO: what about commit->util? */\n-\n \tc->object.parsed = 0;\n }\n \n-- \n2.17.2 (Apple Git-113)\n\n"},{"id":"366016","messageId":"CACsJy8D_gTKWXogPDNW7NQk_a0ChBu28HfGu388hFn3-by_cRw@mail.gmail.com","threadId":"50140","inReplyTo":"20181231235713.76200-1-aburthinds@gmail.com","subject":"Re: [PATCH] doc: remove unneeded TODO for release_commit_memory","fromName":"Duy Nguyen","fromEmail":"pclouds@gmail.com","sentAt":"2019-01-01T10:40:41Z","receivedAt":"2019-01-01T10:41:11Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"On Tue, Jan 1, 2019 at 7:02 AM Albert Burt wrote:\n>\n> The code that was merged with commit 1102405 left in an TODO that\n\nPeople usually use something this to produce the commit reference\n\n git show -s --date=short --pretty='format:%h (%s - %ad)'\n\nwhich produces\n\n110240588d (Merge branch 'sb/object-store-alloc' - 2018-06-25)\n\n> is no longer relevant. It seems as if we can remove this todo.\n> util seems to not be a field of the struct commit,\n> definition of struct commit --> commit.c:27\n> The commit list also, does not contain a field for util.\n\nThere was commit->util, which was deleted in 9d2c97016f (commit.h:\ndelete 'util' field in struct commit - 2018-05-19). You can mention it\ntoo if you reroll this patch.\n\n> ____\n> By making a contribution to this project, I certify that:\n>\n> a. The contribution was created in whole or in part by me and I\n> have the right to submit it under the open source license\n> indicated in the file; or\n>\n> b. The contribution is based upon previous work that, to the best\n> of my knowledge, is covered under an appropriate open source\n> license and I have the right under that license to submit that\n> work with modifications, whether created in whole or in part\n> by me, under the same open source license (unless I am\n> permitted to submit under a different license), as indicated\n> in the file; or\n>\n> c. The contribution was provided directly to me by some other\n> person who certified (a), (b) or (c) and I have not modified\n> it.\n>\n> d. I understand and agree that this project and the contribution\n> are public and that a record of the contribution (including all\n> personal information I submit with it, including my sign-off) is\n> maintained indefinitely and may be redistributed consistent with\n> this project or the open source license(s) involved.\n> ____\n\nI think you can drop this. Your S-o-b below implies all this.\n\n> Signed-off-by: Albert Burt \n> ---\n> commit.c | 2 --\n> 1 file changed, 2 deletions(-)\n>\n> diff --git a/commit.c b/commit.c\n> index 2d94e0b199..2ff6dca0bc 100644\n> --- a/commit.c\n> +++ b/commit.c\n> @@ -357,8 +357,6 @@ void release_commit_memory(struct commit *c)\n> c->index = 0;\n> free_commit_buffer(c);\n> free_commit_list(c->parents);\n> - /* TODO: what about commit->util? */\n> -\n\nObviously correct :)\n\n> c->object.parsed = 0;\n> }\n>\n> --\n> 2.17.2 (Apple Git-113)\n>\n\n\n-- \nDuy\n"},{"id":"366021","messageId":"20190101200818.81273-1-aburthinds@gmail.com","threadId":"50140","inReplyTo":"CACsJy8D_gTKWXogPDNW7NQk_a0ChBu28HfGu388hFn3-by_cRw@mail.gmail.com","subject":"[PATCH v2] doc: remove unneeded TODO for release_commit_memory","fromName":"Albert Burt","fromEmail":"aburthinds@gmail.com","sentAt":"2019-01-01T20:08:18Z","receivedAt":"2019-01-01T20:09:08Z","isPatch":true,"sender":{"key":"aburthinds@gmail.com","avatar":null},"body":"Remove TODO that was left in from:\ncommit 110240588d (Merge branch 'sb/object-store-alloc' - 2018-06-25)\n\nTodo can be removed as:\n9d2c97016f (commit.h: delete 'util' field in struct commit - 2018-05-19)\ndeletes commit->util.\n\nSigned-off-by: Albert Burt \n---\n\nThanks for looking at this for me Duy. I updated some of the changes you\nsuggested. \n\nLet me know if there's anything else that I would need to clean up, or do better.\n:)\n\n commit.c | 2 --\n 1 file changed, 2 deletions(-)\n\ndiff --git a/commit.c b/commit.c\nindex 2d94e0b199..2ff6dca0bc 100644\n--- a/commit.c\n+++ b/commit.c\n@@ -357,8 +357,6 @@ void release_commit_memory(struct commit *c)\n \tc->index = 0;\n \tfree_commit_buffer(c);\n \tfree_commit_list(c->parents);\n-\t/* TODO: what about commit->util? */\n-\n \tc->object.parsed = 0;\n }\n \n-- \n2.17.2 (Apple Git-113)\n\n"},{"id":"366033","messageId":"CACsJy8B4FCkrV0srm8pvcU41DMWoZwDHgW8Wu0j3nZT5JLhEBA@mail.gmail.com","threadId":"50140","inReplyTo":"20190101200818.81273-1-aburthinds@gmail.com","subject":"Re: [PATCH v2] doc: remove unneeded TODO for release_commit_memory","fromName":"Duy Nguyen","fromEmail":"pclouds@gmail.com","sentAt":"2019-01-02T11:17:44Z","receivedAt":"2019-01-02T11:18:11Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"On Wed, Jan 2, 2019 at 3:09 AM Albert Burt wrote:\n>\n> Remove TODO that was left in from:\n> commit 110240588d (Merge branch 'sb/object-store-alloc' - 2018-06-25)\n>\n> Todo can be removed as:\n> 9d2c97016f (commit.h: delete 'util' field in struct commit - 2018-05-19)\n> deletes commit->util.\n>\n> Signed-off-by: Albert Burt \n> ---\n>\n> Thanks for looking at this for me Duy. I updated some of the changes you\n> suggested.\n>\n> Let me know if there's anything else that I would need to clean up, or do better.\n> :)\n\nNope. The patch looks good to me.\n\n>\n> commit.c | 2 --\n> 1 file changed, 2 deletions(-)\n>\n> diff --git a/commit.c b/commit.c\n> index 2d94e0b199..2ff6dca0bc 100644\n> --- a/commit.c\n> +++ b/commit.c\n> @@ -357,8 +357,6 @@ void release_commit_memory(struct commit *c)\n> c->index = 0;\n> free_commit_buffer(c);\n> free_commit_list(c->parents);\n> - /* TODO: what about commit->util? */\n> -\n> c->object.parsed = 0;\n> }\n>\n> --\n> 2.17.2 (Apple Git-113)\n>\n\n\n-- \nDuy\n"},{"id":"366073","messageId":"xmqqftuai4to.fsf@gitster-ct.c.googlers.com","threadId":"50140","inReplyTo":"CACsJy8B4FCkrV0srm8pvcU41DMWoZwDHgW8Wu0j3nZT5JLhEBA@mail.gmail.com","subject":"Re: [PATCH v2] doc: remove unneeded TODO for release_commit_memory","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2019-01-03T07:21:55Z","receivedAt":"2019-01-03T07:22:01Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Duy Nguyen writes:\n\n> On Wed, Jan 2, 2019 at 3:09 AM Albert Burt wrote:\n>>\n>> Remove TODO that was left in from:\n>> commit 110240588d (Merge branch 'sb/object-store-alloc' - 2018-06-25)\n>>\n>> Todo can be removed as:\n>> 9d2c97016f (commit.h: delete 'util' field in struct commit - 2018-05-19)\n>> deletes commit->util.\n>>\n>> Signed-off-by: Albert Burt \n>> ---\n>>\n>> Thanks for looking at this for me Duy. I updated some of the changes you\n>> suggested.\n>>\n>> Let me know if there's anything else that I would need to clean up, or do better.\n>> :)\n>\n> Nope. The patch looks good to me.\n\nYes, but we'll fix this with 6a7895fd (\"commit: prepare\nfree_commit_buffer and release_commit_memory for any repo\",\n2018-12-14) anyway, so I am not sure if this is worth pursuing\nseparately.\n\n>\n>>\n>> commit.c | 2 --\n>> 1 file changed, 2 deletions(-)\n>>\n>> diff --git a/commit.c b/commit.c\n>> index 2d94e0b199..2ff6dca0bc 100644\n>> --- a/commit.c\n>> +++ b/commit.c\n>> @@ -357,8 +357,6 @@ void release_commit_memory(struct commit *c)\n>> c->index = 0;\n>> free_commit_buffer(c);\n>> free_commit_list(c->parents);\n>> - /* TODO: what about commit->util? */\n>> -\n>> c->object.parsed = 0;\n>> }\n>>\n>> --\n>> 2.17.2 (Apple Git-113)\n>>\n"}]}