git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2] doc: remove unneeded TODO for release_commit_memory

From
ABAlbert Burt <aburthinds@gmail.com>
Date
Jan 1, 2019, 20:08 UTC
Message-ID
<20190101200818.81273-1-aburthinds@gmail.com>
In-Reply-To
<CACsJy8D_gTKWXogPDNW7NQk_a0ChBu28HfGu388hFn3-by_cRw@mail.gmail.com>

Remove TODO that was left in from: commit 110240588d (Merge branch 'sb/object-store-alloc' - 2018-06-25)

Todo can be removed as: 9d2c97016f (commit.h: delete 'util' field in struct commit - 2018-05-19) deletes commit->util.

Signed-off-by: Albert Burt <aburthinds@gmail.com>
---

Thanks for looking at this for me Duy. I updated some of the changes you suggested.

Let me know if there's anything else that I would need to clean up, or do better. :)

 commit.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/commit.c b/commit.c
index 2d94e0b199..2ff6dca0bc 100644
--- a/commit.c
+++ b/commit.c
@@ -357,8 +357,6 @@ void release_commit_memory(struct commit *c)
 	c->index = 0;
 	free_commit_buffer(c);
 	free_commit_list(c->parents);
-	/* TODO: what about commit->util? */
-
 	c->object.parsed = 0;
 }
 
-- 
2.17.2 (Apple Git-113)
Previous: Duy NguyenNext: Duy Nguyen
Message 3 of 5 in “doc: remove unneeded TODO for release_commit_memory”
  1. doc: remove unneeded TODO for release_commit_memoryAlbert Burt, Dec 31, 2018
  2. Duy NguyenJan 1, 2019
  3. doc: remove unneeded TODO for release_commit_memoryAlbert Burt, Jan 1, 2019
  4. Duy NguyenJan 2, 2019
  5. Junio C HamanoJan 3, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.