git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] doc: remove unneeded TODO for release_commit_memory

From
ABAlbert Burt <aburthinds@gmail.com>
Date
Dec 31, 2018, 23:57 UTC
Message-ID
<20181231235713.76200-1-aburthinds@gmail.com>

The code that was merged with commit 1102405 left in an TODO that is no longer relevant. It seems as if we can remove this todo. util seems to not be a field of the struct commit, definition of struct commit --> commit.c:27 The commit list also, does not contain a field for util.

____ By making a contribution to this project, I certify that:

a. The contribution was created in whole or in part by me and I
   have the right to submit it under the open source license
   indicated in the file; or
b. The contribution is based upon previous work that, to the best
   of my knowledge, is covered under an appropriate open source
   license and I have the right under that license to submit that
   work with modifications, whether created in whole or in part
   by me, under the same open source license (unless I am
   permitted to submit under a different license), as indicated
   in the file; or
c. The contribution was provided directly to me by some other
   person who certified (a), (b) or (c) and I have not modified
   it.
d. I understand and agree that this project and the contribution
   are public and that a record of the contribution (including all
   personal information I submit with it, including my sign-off) is
   maintained indefinitely and may be redistributed consistent with
   this project or the open source license(s) involved.
____
Signed-off-by: Albert Burt <aburthinds@gmail.com>
---
 commit.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/commit.c b/commit.c
index 2d94e0b199..2ff6dca0bc 100644
--- a/commit.c
+++ b/commit.c
@@ -357,8 +357,6 @@ void release_commit_memory(struct commit *c)
 	c->index = 0;
 	free_commit_buffer(c);
 	free_commit_list(c->parents);
-	/* TODO: what about commit->util? */
-
 	c->object.parsed = 0;
 }
 
-- 
2.17.2 (Apple Git-113)
Next: Duy Nguyen
Message 1 of 5 in “doc: remove unneeded TODO for release_commit_memory”
  1. doc: remove unneeded TODO for release_commit_memoryAlbert Burt, Dec 31, 2018
  2. Duy NguyenJan 1, 2019
  3. doc: remove unneeded TODO for release_commit_memoryAlbert Burt, Jan 1, 2019
  4. Duy NguyenJan 2, 2019
  5. Junio C HamanoJan 3, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.