threads / patch / 49028

patcht3031: update test description to mention desired behavior

Subject: [PATCH] t3031: update test description to mention desired behavior

## tl;dr

2 messages between Aug 3, 2018 and Aug 3, 2018. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Elijah Newren· Aug 3, 2018, 23:09 UTC · lore

This test description looks like it was written with the originally observed behavior ("causes segfault") rather than the desired and now current behavior ("does not cause segfault"). Fix it.

Signed-off-by: Elijah Newren <newren@gmail.com>
---
 t/t3031-merge-criscross.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to t/t3031-merge-criscross.sh +1 −1

diff --git a/t/t3031-merge-criscross.sh b/t/t3031-merge-criscross.sh
index e59b0a32d6..3824756a02 100755
--- a/t/t3031-merge-criscross.sh
+++ b/t/t3031-merge-criscross.sh
@@ -88,7 +88,7 @@ test_expect_success 'setup repo with criss-cross history' '
 	git branch G
 '
 
-test_expect_success 'recursive merge between F and G, causes segfault' '
+test_expect_success 'recursive merge between F and G does not cause segfault' '
 	git merge F
 '

-- 
2.18.0.548.gcd835b18f7

Junio C Hamano· Aug 3, 2018, 23:42 UTC · re: Elijah Newren · lore

Re: [PATCH] t3031: update test description to mention desired behavior

Elijah Newren <newren@gmail.com> writes:

> This test description looks like it was written with the originally
> observed behavior ("causes segfault") rather than the desired and now
> current behavior ("does not cause segfault").  Fix it.

GOod.

Show 18 quoted lines

>
> Signed-off-by: Elijah Newren <newren@gmail.com>
> ---
>  t/t3031-merge-criscross.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t3031-merge-criscross.sh b/t/t3031-merge-criscross.sh
> index e59b0a32d6..3824756a02 100755
> --- a/t/t3031-merge-criscross.sh
> +++ b/t/t3031-merge-criscross.sh
> @@ -88,7 +88,7 @@ test_expect_success 'setup repo with criss-cross history' '
>  	git branch G
>  '
>  
> -test_expect_success 'recursive merge between F and G, causes segfault' '
> +test_expect_success 'recursive merge between F and G does not cause segfault' '
>  	git merge F
>  '