{"thread":{"id":"49028","subject":"[PATCH] t3031: update test description to mention desired behavior","startedAt":"2018-08-03T23:09:29Z","lastAt":"2018-08-03T23:42:21Z","messageCount":2,"participants":["Elijah Newren","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"354457","messageId":"20180803230923.25577-1-newren@gmail.com","threadId":"49028","inReplyTo":null,"subject":"[PATCH] t3031: update test description to mention desired behavior","fromName":"Elijah Newren","fromEmail":"newren@gmail.com","sentAt":"2018-08-03T23:09:23Z","receivedAt":"2018-08-03T23:09:29Z","isPatch":true,"sender":{"key":"newren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5455730?v=4"},"body":"This test description looks like it was written with the originally\nobserved behavior (\"causes segfault\") rather than the desired and now\ncurrent behavior (\"does not cause segfault\").  Fix it.\n\nSigned-off-by: Elijah Newren <newren@gmail.com>\n---\n t/t3031-merge-criscross.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t3031-merge-criscross.sh b/t/t3031-merge-criscross.sh\nindex e59b0a32d6..3824756a02 100755\n--- a/t/t3031-merge-criscross.sh\n+++ b/t/t3031-merge-criscross.sh\n@@ -88,7 +88,7 @@ test_expect_success 'setup repo with criss-cross history' '\n \tgit branch G\n '\n \n-test_expect_success 'recursive merge between F and G, causes segfault' '\n+test_expect_success 'recursive merge between F and G does not cause segfault' '\n \tgit merge F\n '\n \n-- \n2.18.0.548.gcd835b18f7\n\n"},{"id":"354461","messageId":"xmqq8t5nuief.fsf@gitster-ct.c.googlers.com","threadId":"49028","inReplyTo":"20180803230923.25577-1-newren@gmail.com","subject":"Re: [PATCH] t3031: update test description to mention desired behavior","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-08-03T23:42:16Z","receivedAt":"2018-08-03T23:42:21Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Elijah Newren <newren@gmail.com> writes:\n\n> This test description looks like it was written with the originally\n> observed behavior (\"causes segfault\") rather than the desired and now\n> current behavior (\"does not cause segfault\").  Fix it.\n\nGOod.\n\n>\n> Signed-off-by: Elijah Newren <newren@gmail.com>\n> ---\n>  t/t3031-merge-criscross.sh | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/t/t3031-merge-criscross.sh b/t/t3031-merge-criscross.sh\n> index e59b0a32d6..3824756a02 100755\n> --- a/t/t3031-merge-criscross.sh\n> +++ b/t/t3031-merge-criscross.sh\n> @@ -88,7 +88,7 @@ test_expect_success 'setup repo with criss-cross history' '\n>  \tgit branch G\n>  '\n>  \n> -test_expect_success 'recursive merge between F and G, causes segfault' '\n> +test_expect_success 'recursive merge between F and G does not cause segfault' '\n>  \tgit merge F\n>  '\n"}]}