# [PATCH] t3031: update test description to mention desired behavior 2 messages from 2018-08-03 to 2018-08-03. Participants: Elijah Newren, Junio C Hamano. Thread: https://gitlist.dev/t/49028 ## Elijah Newren, 2018-08-03 23:09 Subject: [PATCH] t3031: update test description to mention desired behavior Message-ID: <20180803230923.25577-1-newren@gmail.com> URL: https://gitlist.dev/e/20180803230923.25577-1-newren%40gmail.com ``` This test description looks like it was written with the originally observed behavior ("causes segfault") rather than the desired and now current behavior ("does not cause segfault"). Fix it. Signed-off-by: Elijah Newren --- t/t3031-merge-criscross.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t3031-merge-criscross.sh b/t/t3031-merge-criscross.sh index e59b0a32d6..3824756a02 100755 --- a/t/t3031-merge-criscross.sh +++ b/t/t3031-merge-criscross.sh @@ -88,7 +88,7 @@ test_expect_success 'setup repo with criss-cross history' ' git branch G ' -test_expect_success 'recursive merge between F and G, causes segfault' ' +test_expect_success 'recursive merge between F and G does not cause segfault' ' git merge F ' -- 2.18.0.548.gcd835b18f7 ``` ## Junio C Hamano, 2018-08-03 23:42 Subject: Re: [PATCH] t3031: update test description to mention desired behavior Message-ID: URL: https://gitlist.dev/e/xmqq8t5nuief.fsf%40gitster-ct.c.googlers.com In-Reply-To: <20180803230923.25577-1-newren@gmail.com> ``` Elijah Newren writes: > This test description looks like it was written with the originally > observed behavior ("causes segfault") rather than the desired and now > current behavior ("does not cause segfault"). Fix it. GOod. > > Signed-off-by: Elijah Newren > --- > t/t3031-merge-criscross.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/t/t3031-merge-criscross.sh b/t/t3031-merge-criscross.sh > index e59b0a32d6..3824756a02 100755 > --- a/t/t3031-merge-criscross.sh > +++ b/t/t3031-merge-criscross.sh > @@ -88,7 +88,7 @@ test_expect_success 'setup repo with criss-cross history' ' > git branch G > ' > > -test_expect_success 'recursive merge between F and G, causes segfault' ' > +test_expect_success 'recursive merge between F and G does not cause segfault' ' > git merge F > ' ```