Re: [PATCH] t3031: update test description to mention desired behavior

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 3, 2018, 23:42 UTC
Message-ID: <xmqq8t5nuief.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180803230923.25577-1-newren@gmail.com>

Elijah Newren <newren@gmail.com> writes:

> This test description looks like it was written with the originally
> observed behavior ("causes segfault") rather than the desired and now
> current behavior ("does not cause segfault").  Fix it.

GOod.

Show 18 quoted lines

>
> Signed-off-by: Elijah Newren <newren@gmail.com>
> ---
>  t/t3031-merge-criscross.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t3031-merge-criscross.sh b/t/t3031-merge-criscross.sh
> index e59b0a32d6..3824756a02 100755
> --- a/t/t3031-merge-criscross.sh
> +++ b/t/t3031-merge-criscross.sh
> @@ -88,7 +88,7 @@ test_expect_success 'setup repo with criss-cross history' '
>  	git branch G
>  '
>  
> -test_expect_success 'recursive merge between F and G, causes segfault' '
> +test_expect_success 'recursive merge between F and G does not cause segfault' '
>  	git merge F
>  '