threads / patch / 48969

patcht5562: avoid non-portable "export FOO=bar" construct

Subject: [PATCH] t5562: avoid non-portable "export FOO=bar" construct

## tl;dr

4 messages between Jul 28, 2018 and Jul 30, 2018. Diffs are folded; open one to read it.

replies: 3people: 3as markdown or json

Ramsay Jones· Jul 28, 2018, 22:51 UTC · lore

Commit 6c213e863a ("http-backend: respect CONTENT_LENGTH for receive-pack", 2018-07-27) adds a test which uses the non-portable export construct. Replace it with "FOO=bar && export FOO" instead.

Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Junio,

Could you please put this on top of the 'mk/http-backend-content-length' branch. This test tickles the new "export FOO=bar" check, so the test suite does not run otherwise.

[If Max needs to re-roll that patch series, then he can squash this in.]

BTW, t3404.#4 fails for me, but I think you are already aware of that test failure, right?

Thanks!

ATB, Ramsay Jones

 t/t5562-http-backend-content-length.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Show changes to t/t5562-http-backend-content-length.sh +2 −1
diff --git a/t/t5562-http-backend-content-length.sh b/t/t5562-http-backend-content-length.sh
index 057dcb85d6..43570ce120 100755
--- a/t/t5562-http-backend-content-length.sh
+++ b/t/t5562-http-backend-content-length.sh
@@ -45,7 +45,8 @@ ssize_b100dots() {
 }
 
 test_expect_success 'setup' '
-	export HTTP_CONTENT_ENCODING="identity" &&
+	HTTP_CONTENT_ENCODING="identity" &&
+	export HTTP_CONTENT_ENCODING &&
 	git config http.receivepack true &&
 	test_commit c0 &&
 	test_commit c1 &&

-- 
2.18.0
Eric Sunshine· Jul 29, 2018, 03:13 UTC · re: Ramsay Jones · lore

Re: [PATCH] t5562: avoid non-portable "export FOO=bar" construct

On Sat, Jul 28, 2018 at 6:51 PM Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:

Show 9 quoted lines
> Commit 6c213e863a ("http-backend: respect CONTENT_LENGTH for
> receive-pack", 2018-07-27) adds a test which uses the non-portable
> export construct. Replace it with "FOO=bar && export FOO" instead.
>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
> Could you please put this on top of the 'mk/http-backend-content-length'
> branch. This test tickles the new "export FOO=bar" check, so the test
> suite does not run otherwise.

The "export FOO=bar" check comes from 9968ffff0d (test-lint: detect 'export FOO=bar', 2013-07-08), so is not exactly new.

Perhaps you were thinking of [1] a0a630192d (t/check-non-portable-shell: detect "FOO=bar shell_func", 2018-07-13), when you wrote this, though it is not related to "export FOO=bar" detection.

The patch itself looks fine, by the way.
[1]: https://public-inbox.org/git/20180713055205.32351-5-sunshine@sunshineco.com/
Ramsay Jones· Jul 29, 2018, 15:32 UTC · re: Eric Sunshine · lore

Re: [PATCH] t5562: avoid non-portable "export FOO=bar" construct

On 29/07/18 04:13, Eric Sunshine wrote:
Show 16 quoted lines
> On Sat, Jul 28, 2018 at 6:51 PM Ramsay Jones
> <ramsay@ramsayjones.plus.com> wrote:
>> Commit 6c213e863a ("http-backend: respect CONTENT_LENGTH for
>> receive-pack", 2018-07-27) adds a test which uses the non-portable
>> export construct. Replace it with "FOO=bar && export FOO" instead.
>>
>> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
>> ---
>> Could you please put this on top of the 'mk/http-backend-content-length'
>> branch. This test tickles the new "export FOO=bar" check, so the test
>> suite does not run otherwise.
> 
> The "export FOO=bar" check comes from 9968ffff0d (test-lint: detect
> 'export FOO=bar', 2013-07-08), so is not exactly new.
> 
> Perhaps you were thinking of [1] a0a630192d

Heh, yes you are obviously correct. Although 'thinking' might be being too generous! ;-)

[I can't even claim that it was late ... midnight is actually quite early for me!]

Show 8 quoted lines
> (t/check-non-portable-shell: detect "FOO=bar shell_func", 2018-07-13),
> when you wrote this, though it is not related to "export FOO=bar"
> detection.
> 
> The patch itself looks fine, by the way.
> 
> [1]: https://public-inbox.org/git/20180713055205.32351-5-sunshine@sunshineco.com/
> 
Thanks!

ATB, Ramsay Jones

Max Kirillov· Jul 30, 2018, 03:55 UTC · re: Ramsay Jones · lore

Re: [PATCH] t5562: avoid non-portable "export FOO=bar" construct

> Commit 6c213e863a ("http-backend: respect CONTENT_LENGTH for

receive-pack", 2018-07-27) adds a test which uses the non-portable export construct. Replace it with "FOO=bar && export FOO" instead.

Thank you. Apparently the check is performed by make -C t, and I did not run it like this since I only changed the test.

← back to recent threads