{"thread":{"id":"48969","subject":"[PATCH] t5562: avoid non-portable \"export FOO=bar\" construct","startedAt":"2018-07-28T22:53:29Z","lastAt":"2018-07-30T03:55:16Z","messageCount":4,"participants":["Ramsay Jones","Eric Sunshine","Max Kirillov"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"353804","messageId":"c5b2a072-5058-0d3e-8fb0-52b84bfcdfa9@ramsayjones.plus.com","threadId":"48969","inReplyTo":null,"subject":"[PATCH] t5562: avoid non-portable \"export FOO=bar\" construct","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2018-07-28T22:51:28Z","receivedAt":"2018-07-28T22:53:29Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nCommit 6c213e863a (\"http-backend: respect CONTENT_LENGTH for\nreceive-pack\", 2018-07-27) adds a test which uses the non-portable\nexport construct. Replace it with \"FOO=bar && export FOO\" instead.\n\nSigned-off-by: Ramsay Jones \n---\n\nHi Junio,\n\nCould you please put this on top of the 'mk/http-backend-content-length'\nbranch. This test tickles the new \"export FOO=bar\" check, so the test\nsuite does not run otherwise.\n\n[If Max needs to re-roll that patch series, then he can squash this in.]\n\nBTW, t3404.#4 fails for me, but I think you are already aware of that\ntest failure, right?\n\nThanks!\n\nATB,\nRamsay Jones\n\n t/t5562-http-backend-content-length.sh | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)\n\ndiff --git a/t/t5562-http-backend-content-length.sh b/t/t5562-http-backend-content-length.sh\nindex 057dcb85d6..43570ce120 100755\n--- a/t/t5562-http-backend-content-length.sh\n+++ b/t/t5562-http-backend-content-length.sh\n@@ -45,7 +45,8 @@ ssize_b100dots() {\n }\n \n test_expect_success 'setup' '\n-\texport HTTP_CONTENT_ENCODING=\"identity\" &&\n+\tHTTP_CONTENT_ENCODING=\"identity\" &&\n+\texport HTTP_CONTENT_ENCODING &&\n \tgit config http.receivepack true &&\n \ttest_commit c0 &&\n \ttest_commit c1 &&\n-- \n2.18.0\n"},{"id":"353810","messageId":"CAPig+cSCsOXi4e8idXwLo41rjDREvvtG5P_bNtEWybUbAZj9Hg@mail.gmail.com","threadId":"48969","inReplyTo":"c5b2a072-5058-0d3e-8fb0-52b84bfcdfa9@ramsayjones.plus.com","subject":"Re: [PATCH] t5562: avoid non-portable \"export FOO=bar\" construct","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2018-07-29T03:13:13Z","receivedAt":"2018-07-29T03:16:45Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Sat, Jul 28, 2018 at 6:51 PM Ramsay Jones\n wrote:\n> Commit 6c213e863a (\"http-backend: respect CONTENT_LENGTH for\n> receive-pack\", 2018-07-27) adds a test which uses the non-portable\n> export construct. Replace it with \"FOO=bar && export FOO\" instead.\n>\n> Signed-off-by: Ramsay Jones \n> ---\n> Could you please put this on top of the 'mk/http-backend-content-length'\n> branch. This test tickles the new \"export FOO=bar\" check, so the test\n> suite does not run otherwise.\n\nThe \"export FOO=bar\" check comes from 9968ffff0d (test-lint: detect\n'export FOO=bar', 2013-07-08), so is not exactly new.\n\nPerhaps you were thinking of [1] a0a630192d\n(t/check-non-portable-shell: detect \"FOO=bar shell_func\", 2018-07-13),\nwhen you wrote this, though it is not related to \"export FOO=bar\"\ndetection.\n\nThe patch itself looks fine, by the way.\n\n[1]: https://public-inbox.org/git/20180713055205.32351-5-sunshine@sunshineco.com/\n"},{"id":"353824","messageId":"da1bba33-b2c4-08b4-60f9-d545da56882a@ramsayjones.plus.com","threadId":"48969","inReplyTo":"CAPig+cSCsOXi4e8idXwLo41rjDREvvtG5P_bNtEWybUbAZj9Hg@mail.gmail.com","subject":"Re: [PATCH] t5562: avoid non-portable \"export FOO=bar\" construct","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2018-07-29T15:32:59Z","receivedAt":"2018-07-29T15:33:04Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\n\nOn 29/07/18 04:13, Eric Sunshine wrote:\n> On Sat, Jul 28, 2018 at 6:51 PM Ramsay Jones\n> wrote:\n>> Commit 6c213e863a (\"http-backend: respect CONTENT_LENGTH for\n>> receive-pack\", 2018-07-27) adds a test which uses the non-portable\n>> export construct. Replace it with \"FOO=bar && export FOO\" instead.\n>>\n>> Signed-off-by: Ramsay Jones \n>> ---\n>> Could you please put this on top of the 'mk/http-backend-content-length'\n>> branch. This test tickles the new \"export FOO=bar\" check, so the test\n>> suite does not run otherwise.\n> \n> The \"export FOO=bar\" check comes from 9968ffff0d (test-lint: detect\n> 'export FOO=bar', 2013-07-08), so is not exactly new.\n> \n> Perhaps you were thinking of [1] a0a630192d\n\nHeh, yes you are obviously correct. Although 'thinking' might\nbe being too generous! ;-)\n\n[I can't even claim that it was late ... midnight is actually\nquite early for me!]\n\n> (t/check-non-portable-shell: detect \"FOO=bar shell_func\", 2018-07-13),\n> when you wrote this, though it is not related to \"export FOO=bar\"\n> detection.\n> \n> The patch itself looks fine, by the way.\n> \n> [1]: https://public-inbox.org/git/20180713055205.32351-5-sunshine@sunshineco.com/\n> \n\nThanks!\n\nATB,\nRamsay Jones\n\n"},{"id":"353852","messageId":"CAF7_NFRNcHh2d91s5Sd1QiC-b+9dshjiHH2O-jCfS1gw7fTp+A@mail.gmail.com","threadId":"48969","inReplyTo":"c5b2a072-5058-0d3e-8fb0-52b84bfcdfa9@ramsayjones.plus.com","subject":"Re: [PATCH] t5562: avoid non-portable \"export FOO=bar\" construct","fromName":"Max Kirillov","fromEmail":"max@max630.net","sentAt":"2018-07-30T03:55:12Z","receivedAt":"2018-07-30T03:55:16Z","isPatch":true,"sender":{"key":"max@max630.net","avatar":"https://avatars.githubusercontent.com/u/381560?v=4"},"body":"> Commit 6c213e863a (\"http-backend: respect CONTENT_LENGTH for\nreceive-pack\", 2018-07-27) adds a test which uses the non-portable\nexport construct. Replace it with \"FOO=bar && export FOO\" instead.\n\nThank you. Apparently the check is performed by make -C t, and I did\nnot run it like this since I only changed the test.\n"}]}