git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] t5562: avoid non-portable "export FOO=bar" construct

From
Ramsay Jones <ramsay@ramsayjones.plus.com>
Date
Jul 28, 2018, 22:51 UTC
Message-ID
<c5b2a072-5058-0d3e-8fb0-52b84bfcdfa9@ramsayjones.plus.com>

Commit 6c213e863a ("http-backend: respect CONTENT_LENGTH for receive-pack", 2018-07-27) adds a test which uses the non-portable export construct. Replace it with "FOO=bar && export FOO" instead.

Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Junio,

Could you please put this on top of the 'mk/http-backend-content-length' branch. This test tickles the new "export FOO=bar" check, so the test suite does not run otherwise.

[If Max needs to re-roll that patch series, then he can squash this in.]

BTW, t3404.#4 fails for me, but I think you are already aware of that test failure, right?

Thanks!

ATB, Ramsay Jones

 t/t5562-http-backend-content-length.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/t/t5562-http-backend-content-length.sh b/t/t5562-http-backend-content-length.sh
index 057dcb85d6..43570ce120 100755
--- a/t/t5562-http-backend-content-length.sh
+++ b/t/t5562-http-backend-content-length.sh
@@ -45,7 +45,8 @@ ssize_b100dots() {
 }
 
 test_expect_success 'setup' '
-	export HTTP_CONTENT_ENCODING="identity" &&
+	HTTP_CONTENT_ENCODING="identity" &&
+	export HTTP_CONTENT_ENCODING &&
 	git config http.receivepack true &&
 	test_commit c0 &&
 	test_commit c1 &&
-- 
2.18.0
Next: Eric Sunshine
Message 1 of 4 in “t5562: avoid non-portable "export FOO=bar" construct”
  1. t5562: avoid non-portable "export FOO=bar" constructRamsay Jones, Jul 28, 2018
  2. Eric SunshineJul 29, 2018
  3. Ramsay JonesJul 29, 2018
  4. Max KirillovJul 30, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.