# [PATCH] t5562: avoid non-portable "export FOO=bar" construct 4 messages from 2018-07-28 to 2018-07-30. Participants: Ramsay Jones, Eric Sunshine, Max Kirillov. Thread: https://gitlist.dev/t/48969 ## Ramsay Jones, 2018-07-28 22:51 Subject: [PATCH] t5562: avoid non-portable "export FOO=bar" construct Message-ID: URL: https://gitlist.dev/e/c5b2a072-5058-0d3e-8fb0-52b84bfcdfa9%40ramsayjones.plus.com ``` Commit 6c213e863a ("http-backend: respect CONTENT_LENGTH for receive-pack", 2018-07-27) adds a test which uses the non-portable export construct. Replace it with "FOO=bar && export FOO" instead. Signed-off-by: Ramsay Jones --- Hi Junio, Could you please put this on top of the 'mk/http-backend-content-length' branch. This test tickles the new "export FOO=bar" check, so the test suite does not run otherwise. [If Max needs to re-roll that patch series, then he can squash this in.] BTW, t3404.#4 fails for me, but I think you are already aware of that test failure, right? Thanks! ATB, Ramsay Jones t/t5562-http-backend-content-length.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/t/t5562-http-backend-content-length.sh b/t/t5562-http-backend-content-length.sh index 057dcb85d6..43570ce120 100755 --- a/t/t5562-http-backend-content-length.sh +++ b/t/t5562-http-backend-content-length.sh @@ -45,7 +45,8 @@ ssize_b100dots() { } test_expect_success 'setup' ' - export HTTP_CONTENT_ENCODING="identity" && + HTTP_CONTENT_ENCODING="identity" && + export HTTP_CONTENT_ENCODING && git config http.receivepack true && test_commit c0 && test_commit c1 && -- 2.18.0 ``` ## Eric Sunshine, 2018-07-29 03:13 Subject: Re: [PATCH] t5562: avoid non-portable "export FOO=bar" construct Message-ID: URL: https://gitlist.dev/e/CAPig%2BcSCsOXi4e8idXwLo41rjDREvvtG5P_bNtEWybUbAZj9Hg%40mail.gmail.com In-Reply-To: ``` On Sat, Jul 28, 2018 at 6:51 PM Ramsay Jones wrote: > Commit 6c213e863a ("http-backend: respect CONTENT_LENGTH for > receive-pack", 2018-07-27) adds a test which uses the non-portable > export construct. Replace it with "FOO=bar && export FOO" instead. > > Signed-off-by: Ramsay Jones > --- > Could you please put this on top of the 'mk/http-backend-content-length' > branch. This test tickles the new "export FOO=bar" check, so the test > suite does not run otherwise. The "export FOO=bar" check comes from 9968ffff0d (test-lint: detect 'export FOO=bar', 2013-07-08), so is not exactly new. Perhaps you were thinking of [1] a0a630192d (t/check-non-portable-shell: detect "FOO=bar shell_func", 2018-07-13), when you wrote this, though it is not related to "export FOO=bar" detection. The patch itself looks fine, by the way. [1]: https://public-inbox.org/git/20180713055205.32351-5-sunshine@sunshineco.com/ ``` ## Ramsay Jones, 2018-07-29 15:32 Subject: Re: [PATCH] t5562: avoid non-portable "export FOO=bar" construct Message-ID: URL: https://gitlist.dev/e/da1bba33-b2c4-08b4-60f9-d545da56882a%40ramsayjones.plus.com In-Reply-To: ``` On 29/07/18 04:13, Eric Sunshine wrote: > On Sat, Jul 28, 2018 at 6:51 PM Ramsay Jones > wrote: >> Commit 6c213e863a ("http-backend: respect CONTENT_LENGTH for >> receive-pack", 2018-07-27) adds a test which uses the non-portable >> export construct. Replace it with "FOO=bar && export FOO" instead. >> >> Signed-off-by: Ramsay Jones >> --- >> Could you please put this on top of the 'mk/http-backend-content-length' >> branch. This test tickles the new "export FOO=bar" check, so the test >> suite does not run otherwise. > > The "export FOO=bar" check comes from 9968ffff0d (test-lint: detect > 'export FOO=bar', 2013-07-08), so is not exactly new. > > Perhaps you were thinking of [1] a0a630192d Heh, yes you are obviously correct. Although 'thinking' might be being too generous! ;-) [I can't even claim that it was late ... midnight is actually quite early for me!] > (t/check-non-portable-shell: detect "FOO=bar shell_func", 2018-07-13), > when you wrote this, though it is not related to "export FOO=bar" > detection. > > The patch itself looks fine, by the way. > > [1]: https://public-inbox.org/git/20180713055205.32351-5-sunshine@sunshineco.com/ > Thanks! ATB, Ramsay Jones ``` ## Max Kirillov, 2018-07-30 03:55 Subject: Re: [PATCH] t5562: avoid non-portable "export FOO=bar" construct Message-ID: URL: https://gitlist.dev/e/CAF7_NFRNcHh2d91s5Sd1QiC-b%2B9dshjiHH2O-jCfS1gw7fTp%2BA%40mail.gmail.com In-Reply-To: ``` > Commit 6c213e863a ("http-backend: respect CONTENT_LENGTH for receive-pack", 2018-07-27) adds a test which uses the non-portable export construct. Replace it with "FOO=bar && export FOO" instead. Thank you. Apparently the check is performed by make -C t, and I did not run it like this since I only changed the test. ```