threads / discuss / 48541

symbol string_list_appendf() unused

Subject: symbol string_list_appendf() unused

## tl;dr

4 messages between May 21, 2018 and May 22, 2018.

replies: 3people: 3as markdown or json

Ramsay Jones· May 21, 2018, 23:56 UTC · lore
Hi Martin,

I strongly suspect that I haven't followed the discussion on the list closely enough, but your 'ma/unpack-trees-free-msgs' branch in 'pu', seems to define string_list_appendf() but then never call it. This is despite commit 40ebd6c7b0 ("string-list: provide `string_list_appendf()`", 2018-05-20) claiming that: 'The next commit will add a user'. ;-)

Have I missed something?

ATB, Ramsay Jones

Junio C Hamano· May 21, 2018, 23:59 UTC · re: Ramsay Jones · lore

Re: symbol string_list_appendf() unused

Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
Show 8 quoted lines
> I strongly suspect that I haven't followed the discussion on
> the list closely enough, but your 'ma/unpack-trees-free-msgs'
> branch in 'pu', seems to define string_list_appendf() but then
> never call it. This is despite commit 40ebd6c7b0 ("string-list:
> provide `string_list_appendf()`", 2018-05-20) claiming that:
> 'The next commit will add a user'. ;-)
>
> Have I missed something?

Yes, I pushed out a tentative "how about doing it this way" update that goes alongside his version, making some solutions (including the function you found) he had obsoleted, yet without removing them. That is what you saw on 'pu'.

There is a reroll by Martin that ties all the loose ends.

Thanks for paying great attention to the details. Always appreciated.

Ramsay Jones· May 22, 2018, 00:08 UTC · re: Junio C Hamano · lore

Re: symbol string_list_appendf() unused

On 22/05/18 00:59, Junio C Hamano wrote:
Show 17 quoted lines
> Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
> 
>> I strongly suspect that I haven't followed the discussion on
>> the list closely enough, but your 'ma/unpack-trees-free-msgs'
>> branch in 'pu', seems to define string_list_appendf() but then
>> never call it. This is despite commit 40ebd6c7b0 ("string-list:
>> provide `string_list_appendf()`", 2018-05-20) claiming that:
>> 'The next commit will add a user'. ;-)
>>
>> Have I missed something?
> 
> Yes, I pushed out a tentative "how about doing it this way" update
> that goes alongside his version, making some solutions (including
> the function you found) he had obsoleted, yet without removing
> them.  That is what you saw on 'pu'.
> 
> There is a reroll by Martin that ties all the loose ends.
Ah, OK, sorry for the noise.
Thanks!

ATB, Ramsay Jones

Martin Ågren· May 22, 2018, 10:55 UTC · re: Ramsay Jones · lore

Re: symbol string_list_appendf() unused

Hi Ramsay
On 22 May 2018 at 02:08, Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:
> On 22/05/18 00:59, Junio C Hamano wrote:
>> There is a reroll by Martin that ties all the loose ends.
>
> Ah, OK, sorry for the noise.

No worry. Thanks for pointing out the unused function to me. I appreciate it.

Martin

← back to recent threads