git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: symbol string_list_appendf() unused

From
Ramsay Jones <ramsay@ramsayjones.plus.com>
Date
May 22, 2018, 00:08 UTC
Message-ID
<50d629b9-bf89-77af-a1ee-6175745c5e42@ramsayjones.plus.com>
In-Reply-To
<xmqqvabgzhjr.fsf@gitster-ct.c.googlers.com>
On 22/05/18 00:59, Junio C Hamano wrote:
Show 17 quoted lines
> Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
> 
>> I strongly suspect that I haven't followed the discussion on
>> the list closely enough, but your 'ma/unpack-trees-free-msgs'
>> branch in 'pu', seems to define string_list_appendf() but then
>> never call it. This is despite commit 40ebd6c7b0 ("string-list:
>> provide `string_list_appendf()`", 2018-05-20) claiming that:
>> 'The next commit will add a user'. ;-)
>>
>> Have I missed something?
> 
> Yes, I pushed out a tentative "how about doing it this way" update
> that goes alongside his version, making some solutions (including
> the function you found) he had obsoleted, yet without removing
> them.  That is what you saw on 'pu'.
> 
> There is a reroll by Martin that ties all the loose ends.
Ah, OK, sorry for the noise.
Thanks!

ATB, Ramsay Jones

Previous: Junio C HamanoNext: Martin Ågren
Message 3 of 4 in “symbol string_list_appendf() unused”
  1. Ramsay JonesMay 21, 2018
  2. Junio C HamanoMay 21, 2018
  3. Ramsay JonesMay 22, 2018
  4. Martin ÅgrenMay 22, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.