{"thread":{"id":"48541","subject":"symbol string_list_appendf() unused","startedAt":"2018-05-21T23:56:25Z","lastAt":"2018-05-22T10:55:20Z","messageCount":4,"participants":["Ramsay Jones","Junio C Hamano","Martin Ågren"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"348264","messageId":"d203f6ef-f684-cf6b-07b0-553b6b79e189@ramsayjones.plus.com","threadId":"48541","inReplyTo":null,"subject":"symbol string_list_appendf() unused","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2018-05-21T23:56:21Z","receivedAt":"2018-05-21T23:56:25Z","isPatch":false,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"Hi Martin,\n\nI strongly suspect that I haven't followed the discussion on\nthe list closely enough, but your 'ma/unpack-trees-free-msgs'\nbranch in 'pu', seems to define string_list_appendf() but then\nnever call it. This is despite commit 40ebd6c7b0 (\"string-list:\nprovide `string_list_appendf()`\", 2018-05-20) claiming that:\n'The next commit will add a user'. ;-)\n\nHave I missed something?\n\nATB,\nRamsay Jones\n\n"},{"id":"348265","messageId":"xmqqvabgzhjr.fsf@gitster-ct.c.googlers.com","threadId":"48541","inReplyTo":"d203f6ef-f684-cf6b-07b0-553b6b79e189@ramsayjones.plus.com","subject":"Re: symbol string_list_appendf() unused","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-05-21T23:59:36Z","receivedAt":"2018-05-21T23:59:42Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ramsay Jones <ramsay@ramsayjones.plus.com> writes:\n\n> I strongly suspect that I haven't followed the discussion on\n> the list closely enough, but your 'ma/unpack-trees-free-msgs'\n> branch in 'pu', seems to define string_list_appendf() but then\n> never call it. This is despite commit 40ebd6c7b0 (\"string-list:\n> provide `string_list_appendf()`\", 2018-05-20) claiming that:\n> 'The next commit will add a user'. ;-)\n>\n> Have I missed something?\n\nYes, I pushed out a tentative \"how about doing it this way\" update\nthat goes alongside his version, making some solutions (including\nthe function you found) he had obsoleted, yet without removing\nthem.  That is what you saw on 'pu'.\n\nThere is a reroll by Martin that ties all the loose ends.\n\nThanks for paying great attention to the details. Always\nappreciated.\n\n"},{"id":"348268","messageId":"50d629b9-bf89-77af-a1ee-6175745c5e42@ramsayjones.plus.com","threadId":"48541","inReplyTo":"xmqqvabgzhjr.fsf@gitster-ct.c.googlers.com","subject":"Re: symbol string_list_appendf() unused","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2018-05-22T00:08:43Z","receivedAt":"2018-05-22T00:08:48Z","isPatch":false,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\n\nOn 22/05/18 00:59, Junio C Hamano wrote:\n> Ramsay Jones <ramsay@ramsayjones.plus.com> writes:\n> \n>> I strongly suspect that I haven't followed the discussion on\n>> the list closely enough, but your 'ma/unpack-trees-free-msgs'\n>> branch in 'pu', seems to define string_list_appendf() but then\n>> never call it. This is despite commit 40ebd6c7b0 (\"string-list:\n>> provide `string_list_appendf()`\", 2018-05-20) claiming that:\n>> 'The next commit will add a user'. ;-)\n>>\n>> Have I missed something?\n> \n> Yes, I pushed out a tentative \"how about doing it this way\" update\n> that goes alongside his version, making some solutions (including\n> the function you found) he had obsoleted, yet without removing\n> them.  That is what you saw on 'pu'.\n> \n> There is a reroll by Martin that ties all the loose ends.\n\nAh, OK, sorry for the noise.\n\nThanks!\n\nATB,\nRamsay Jones\n\n"},{"id":"348293","messageId":"CAN0heSrTpWGqCRMfhhyGqCX7TcBUKXbJWJp0yDy0cLQdhhwdHQ@mail.gmail.com","threadId":"48541","inReplyTo":"50d629b9-bf89-77af-a1ee-6175745c5e42@ramsayjones.plus.com","subject":"Re: symbol string_list_appendf() unused","fromName":"Martin Ågren","fromEmail":"martin.agren@gmail.com","sentAt":"2018-05-22T10:55:16Z","receivedAt":"2018-05-22T10:55:20Z","isPatch":false,"sender":{"key":"martin.agren@gmail.com","avatar":null},"body":"Hi Ramsay\n\nOn 22 May 2018 at 02:08, Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:\n> On 22/05/18 00:59, Junio C Hamano wrote:\n\n>> There is a reroll by Martin that ties all the loose ends.\n>\n> Ah, OK, sorry for the noise.\n\nNo worry. Thanks for pointing out the unused function to me. I\nappreciate it.\n\nMartin\n"}]}